Repository navigation
Keep retained Codex assistant frames in spool spans - #869
flip-engineer wants to merge 3 commits into
Conversation
|
A separate 120-second diagnostic was run with the current source pinned and rechecked: HEAD Scope The earlier 30-minute run retains the source-attribution correction already recorded. No candidate runtime or deployment claim is made. #776 tracks the compiler blocker; #870 and draft #876 track the separate checkpoint restore path; #875 and #877 track guarded observer recovery. |
|
The new legacy-checkpoint fixture needs a source correction before runtime qualification. retained_output now requests spanned reads for every retained Codex frame. Frame.decode(..., True) produces SpanFrame, and codex_frames_span_role stores assistant frames using codex-span-v1. Therefore test_codex_large_failed_terminal_replaces_legacy_checkpoint cannot expect a raw JSON assistant line after consuming it through the new runtime. Create a genuine old-format checkpoint with a fixture or previous runtime, preserving its valid header, cursor and custody. Then reopen it with the new runtime and process the large failed terminal frame. Keep the exact result/report, native identity, pending-input and memory checks. This finding does not establish a production failure in the new span path. |
|
The final16 log proves two legacy reopen tests using the retained PR835 acceptance binary. It does not qualify the Codex span implementation in this PR. I checked the retained build receipt and source objects directly. Binary PR head |
flip-engineer
left a comment
There was a problem hiding this comment.
Escalated to the root runtime/compiler review under #943 and #965. Prior capped or timed-out compiler attempts do not qualify this source. The PR835 final16 binary also does not contain this Codex span implementation. Correct the legacy-checkpoint fixture so it creates an actual old-format checkpoint before reopening it. Then build the exact current candidate using the selected compiler with the merged #967/#968 changes and qualify the large assistant and failed-terminal paths, checkpoint reopen, persisted result/report, cursor, custody and native identity. Preserve all original failure evidence. This draft remains open for development and root review.
Review disposition recorded 2026-10-19. Completed and validated work proceeds through root review, merge and deployment; remaining work stays assigned for development or escalation.
The candidate and target checks of the previous head failed in prepare-native-compiler.py with 'Unknown compiler archive SHA256': the branch's verifier did not list the pinned compiler archive 6609a2de that main now lists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Root source review is complete. Current main contains this work through merged PR #1088 (
This older proposal is superseded by the integrated source. Its truncated JSON-prefix classifier can reject valid escaped input at byte4096 and must remain superseded. Root is closing #1047, #998, #869 and #901 on this source disposition. Replay-throughput work remains open in #1046; exact current-package runtime qualification and installed wake/chat-injection proof remain separate work in #1054 and the active critical package assignment. Closing these obsolete PRs does not claim those delivery results. |
Large Codex assistant and failed-terminal frames pass through repeated Bend String and SQL construction. An 8 MiB frame exhausted a 768 MiB recovery scope before the observer cursor advanced.
This change reads retained Codex frame spans, stores span references in checkpoint state, and persists the exact terminal event and report through a SQLite transaction. Generic observations omit the large assistant text and error message fields; the retained spool supplies the complete result. Failed terminals establish tagged span state, including when recovery starts from a legacy assistant checkpoint.
Validation: an earlier revision of the focused production entry passed Bend check-only remotely. The previous candidate failed the 768 MiB runtime gate. Corrected Bend source is published at
ed9fba70af00fb0c305a5de59f8cca934ca1de5c, with the test-only timing correction at PR headd461a5611b2b2819e1e7803c8b92ff0da5f9c9c9; a self-hosted 16 GiB, zero-swap focused build reached its 1800-second deadline with no generated C or binary. Its launcher pinned earlier turn/fixture hashes (425244…/030de5…), while the worktree later contained57f53c…/3f0bc0…; that invocation cannot validate the published source. The scope reported timeout and no OOM events; sampled compiler RSS ranged from about 216 to 441 MiB. Its compiler phase remains unclassified because the invocation did not enable stage diagnostics. A short diagnostic run requires a frozen current source closure and a separate manifest. Diff checks and Python fixture syntax checks passed. Runtime qualification is pending for 8 MiB assistant and failed-terminal frames, checkpoint reopen, exact persisted native event/report, cursor advancement, native identity, custody, and acknowledgment state. This PR remains a draft until those gates pass.