Repository navigation
fix(core): DuplicateDMLOperation handles JSON-sourced boolean flow metadata - #309
Merged
Merged
Conversation
…w metadata allowBack/showFooter compared strictly against the string "true", so flows parsed from Tooling API JSON (real booleans) never matched: violations were silently missed and the back-disabled reset never fired.
RubenHalman
force-pushed
the
fix/duplicate-dml-json-boolean
branch
from
October 5, 2026 18:37
b673f6b to
a7c44e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuplicateDMLOperationcomparedallowBack/showFooterstrictly against the string"true", so flows built from Tooling API JSON (real booleans, e.g. the Salesforce app fetchingFlow.Metadata) never matched: violations went unreported and the back-disabled reset never fired.isTruehelper (matches the coercion pattern already used inMissingNullHandler.tsandRecordIdAsString.ts) and used it in all three comparisons.Impact
Any consumer that hands core Tooling API JSON instead of parsed XML is affected, including Salesforce Inspector Reloaded and Org Check, as well as the LFS Salesforce app. On those, this rule silently reports nothing on screens with back navigation, and the reset fires on every screen.
Scope note
Evaluated the "coerce booleans once at Flow construction" structural alternative suggested on the ticket. Decided against it for this fix: it would touch shared
Flow/FlowNodeparsing broadly for every rule, which is a bigger blast radius than this scoped bug warrants. The localisTruehelper matches the existing per-rule pattern and is the minimal correct fix.Rollout to
force-app/main/default/staticresources/LFS_Core.jsin the LFS Salesforce app repo is a separate follow-up once this lands in a core release — not bundled into an unreleased build here.Test plan
npx jest— full core suite green except pre-existing, unrelatedSanityTest.test.tsUMD-global failure (confirmed present onmainbefore this change, needs a UMD build artifact)tsc --noEmitcleanPlane: LFS-15