Skip to content

ci: validate SignalRGB releases against main - #24

Merged
MAJ224 merged 1 commit into
developfrom
chore/release-main-ancestry
Oct 27, 2026
Merged

MAJ224 merged 1 commit into
developfrom
chore/release-main-ancestry

Conversation

@MAJ224

@MAJ224 MAJ224 commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Checks out full history and validates tag pushes before restoring or assembling a release: tags must match vMAJOR.MINOR.PATCH, match the plugin manifest version, and point to origin/main history. Failed fetches and ancestry checks fail closed. PR and workflow_dispatch packaging dry runs remain available without publishing.

Verification: Release build has 0 warnings/errors; 12/12 tests pass. The actual inline guard parses and passes simulated main ancestry while rejecting develop-only/unmerged commits, Git/fetch errors, malformed tags and version mismatches. Build servers shut down. No live output, tags, releases or package publication performed.

Part of FocusRGB/FocusRGB#155. Antigravity: please review.

Assisted-by: OpenAI Codex

@MAJ224 MAJ224 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review at head 23df7c0: ready to merge

What was checked

  • Checked .github/workflows/release.yml:26 where actions/checkout@v7 now uses fetch-depth: 0 to ensure full commit history is available for ancestry queries.
  • Checked .github/workflows/release.yml:28-46 which validates tag format (^v([0-9]+\.[0-9]+\.[0-9]+)$), verifies that src/FocusRgb.Plugin.SignalRgb/focusrgb-plugin.json has manifest.version == $tagVersion, fetches origin/main, and executes git merge-base --is-ancestor $env:GITHUB_SHA origin/main.
  • Traced adversarial cases:
    1. Tag push on unmerged develop commit: merge-base exits with code 1; line 44 intercepts and throws "Release commits must belong to main history.", halting before dotnet restore or artifact assembly.
    2. Manifest version mismatch: if a tag v0.3.0 is pushed while src/FocusRgb.Plugin.SignalRgb/focusrgb-plugin.json specifies 0.2.0, line 38 aborts before build.
    3. PR / workflow dispatch: non-push events skip the validation block (if: github.event_name == 'push'), allowing dry-run test builds and packaging verification to proceed cleanly.
  • Required CI (branch-policy, build, release) passed at head 23df7c0.

What was not checked

  • Did not push release tags or publish a GitHub release (manual step).
  • Did not perform live hardware RGB illumination tests (manual step).
  • Local test execution not run; relied on GitHub Actions CI.

Assisted-by: Antigravity

@MAJ224
MAJ224 merged commit 32c809d into develop Oct 27, 2026
4 checks passed
@MAJ224
MAJ224 deleted the chore/release-main-ancestry branch October 27, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant