Repository navigation
Conversation
Assisted-by: OpenAI Codex
…faults feat: show detected Steam libraries in Configure defaults
Assisted-by: OpenAI Codex
chore: prepare Steam plugin v0.1.2
Contributor
Author
|
Antigravity: please review the release integration PR at current head Merge into main, tag v0.1.2 and release publication remain manual steps. No tag or publication has been performed. Assisted-by: OpenAI Codex |
MAJ224
commented
Oct 30, 2026
MAJ224
left a comment
Contributor
Author
There was a problem hiding this comment.
Review at head 63a6390: ready to merge
Checked
- Clean release integration (
develop→main):- Verified diff between
origin/main(b6b00a7) anddevelophead63a6390contains strictly the reviewed PR #17 changes and PR #18 version bump. - In
src/FocusRgb.Plugin.Steam/FocusRgb.Plugin.Steam.csproj:4andsrc/FocusRgb.Plugin.Steam/focusrgb-plugin.json:4, version is0.1.2. - In
src/FocusRgb.Plugin.Steam/focusrgb-settings.schema.json:7,14, field display names are"Steam Path"and"Scanned Libraries". - In
src/FocusRgb.Plugin.Steam/SteamLibrarySettings.cs:73,100-128, detected libraries are parsed and populated intodefaults.jsonwith bounded 4 MB buffer and 64-library limit. - In
tests/FocusRgb.Plugin.Steam.Tests/PluginManifestTests.csandSteamLibrarySettingsTests.cs:19,43-74,167-168, all test suites cover the manifest sync, schema labels, and deduplication.
- Verified diff between
- Protocol & contract preservation:
- Plugin schemaVersion (1), contractVersion ("1.2"), ID ("steam"), and capability resource requirements (
["filesystem.read"]) remain strictly identical.
- Plugin schemaVersion (1), contractVersion ("1.2"), ID ("steam"), and capability resource requirements (
- Workflow & publication constraints:
- CI passed on all checks (
branch-policy,build, andreleasedry-run). Package publication was skipped as intended. - Merging into
main, taggingv0.1.2, and triggering publication remain manual steps.
- CI passed on all checks (
Not checked locally
- Relied on green CI (
branch-policy,build, andreleasedry-run passed on GitHub Actions run 41071026589 / 41071026763 / 41071026599). Live GitHub release tag creation remains a manual step.
Blockers
None.
Non-blocking nits
None.
Assisted-by: Antigravity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the Steam 0.1.2 pre-release by integrating develop into main.
Includes the Steam Path / Scanned Libraries labels and detected library defaults from #17, plus the synchronized project/manifest version bump from #18. Saved settings remain authoritative, and SDK/contract version remains 1.2 with unchanged filesystem.read permissions.
Verification: local Release build at the reviewed version-bump head had 0 warnings/errors and 48/48 tests passed. Branch-policy, build and release packaging checks passed on #18; publication was skipped. CI will run again on this release PR.
Manual steps: review and merge this PR into main, then create tag v0.1.2 on main and verify pre-release publication. This PR does not create tags or publish a release. Live desktop/hardware/startup acceptance remains tracked in FocusRGB/FocusRGB#176; stabilization gate FocusRGB/FocusRGB#124 stays open.
Assisted-by: OpenAI Codex