Repository navigation
ci: require main ancestry for SDK publication - #19
Merged
Merged
Conversation
Assisted-by: OpenAI Codex
Closed
4 tasks done
MAJ224
commented
Oct 27, 2026
MAJ224
left a comment
Contributor
Author
There was a problem hiding this comment.
Review at head a2b0e6b: ready to merge
What was checked
- Checked
.github/workflows/publish-plugin-sdk.yml:45-48where ancestry verification now fetches onlyorigin/main(git fetch origin --no-tags "+refs/heads/main:refs/remotes/origin/main") and checksgit merge-base --is-ancestor $env:GITHUB_SHA origin/main. - Verified that the prior fallback allowing
origin/developancestry was cleanly removed, aligning with the workspace requirement that packages and publications must be strictly based onmainhistory. - Traced adversarial path: a tag
sdk-dotnet-v1.2.1-beta.1pointing to a commit that exists only ondevelopwill fail the ancestry check at line 48 with exit code 1 ($LASTEXITCODE -ne 0), immediately throwing"SDK release commits must belong to main history."and aborting beforedotnet restore,dotnet pack, or NuGet push at line 109. - Traced network failure path: if
origin/mainref cannot be fetched, line 46 throws"Could not refresh main history."fail-closed. - Verified that
workflow_dispatchpackaging dry-run remains non-publishing (gated byif: github.event_name == 'push'on line 81). - Required CI (
branch-policy,build) passed at heada2b0e6b.
What was not checked
- Did not push actual release tags or execute live package publishing to
nuget.org(manual step). - Local test execution not run; relied on GitHub Actions CI.
Assisted-by: Antigravity
23 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires SDK packaging/publication commits to belong to origin/main history. The tag/package version guards remain intact; only main is fetched for ancestry validation, and failed fetch/ancestry checks stop before restore, pack or login. workflow_dispatch also requires main ancestry and remains non-publishing.
Verification: Release build has 0 warnings/errors; 35/35 tests pass against spec-v1.2.0. The actual inline PowerShell guard was parsed and exercised with simulated Git results: main accepted; develop-only/unmerged ancestry, Git errors, fetch failure, malformed tags and mismatched versions rejected. No tags, releases or packages created.
Part of FocusRGB/FocusRGB#155. Antigravity: please review.
Assisted-by: OpenAI Codex