Repository navigation
ci: extend Vitest pilot to workspace transitions (#651) - #667
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Fooftilly
requested a deployment
to
project-automation
October 14, 2026 15:00 — with
GitHub Actions
In progress
24 of 64 tasks
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Next incremental B1 coverage slice under #651, following merged #666.
Expand the same informational Vitest coverage workflow to include
frontend-app/src/workspace/transitions.tsusing the existingsrc/workspace/workspace.test.tstests. Workspace state transitions affect pane visibility, tab relocation, focus, and safe close/mode changes. This extends the coverage sample to an important correctness-sensitive area without changing runtime behavior.Small, bounded scope
.github/workflows/vitest-coverage-pilot.yml.npm ci, and the same existing job/check. No new dependencies, jobs, artifacts, or workflow permissions.lifecycle/tab-leave.ts,lifecycle/owner-resource.ts,query/retry.ts, andworkspace/transitions.ts.Verification
Run the changed Vitest coverage pilot. Verify that the additional
workspace/transitions.tsmodule appears in the Actions summary, all four suites pass, and both line and branch denominators are nonzero. Do not extrapolate to frontend-wide coverage.Check that prior three-module measurements remain stable (from ci: expand Vitest coverage to owner-resource lifecycle (#651) #666:
tab-leave.ts77/94 lines and 53/84 branches;owner-resource.ts71/71 lines and 53/61 branches;retry.ts7/7 lines and 6/6 branches).Confirm actionlint, zizmor, Static Analysis/Vue tests, PRKS Test Gate, CodeQL and the E2E planner remain green; review inline findings and fix any confirmed defects before requesting a merge.
Verified on the synchronized latest head: Vitest coverage run 38588806263 passed 56/56 tests in four suites, with these measured scoped results:
tab-leave.tsowner-resource.tsretry.tsworkspace/transitions.tsThe initial PR-opening event unexpectedly produced no ordinary
pull_requestworkflows and left GitHub mergeability undetermined. A formatting-only follow-up to split the four test arguments across lines emitted asynchronizeevent: all eight PR checks started, mergeability became true, and the focused pilot passed.Base
master@345193bc77ecbf5dc82600cabaf2705fe796be2d.Refs #651, #666. Do not auto-merge: the maintainer explicitly approves each merge.