Repository navigation
test(visual): attribute synthetic capture failures without leaking browser details (#651) - #935
Merged
Merged
Conversation
…ithout browser data
|
Note The title starts with
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
24 of 64 tasks
Owner
Author
|
@coderabbitai review |
|
…eaches intended phase
Owner
Author
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The existing five-scene local visual regression pilot tests only disposable research fixtures, but its current Python/Playwright failures can be difficult to triage: a timeout or exception prints an unbounded Playwright message without immediately identifying which capture phase failed. Playwright traces can include selectors, URLs and page text, which should not become standard CI output. This targets #651 D3 and #857 without expanding the testing matrix.
Change
VisualCaptureFailure(stage, exception class), withholding the raw Playwright exception/message. Do not treat any failure as a pass or ignore the strict collector.No screenshot or baseline update, new framework/workflow/package, altered pixel thresholds, new required gate or external upload. The normal fixture-only visual pilot remains authoritative; do not merge without maintainer approval.
Related: #651 D3 and #857.