Skip to content

refactor(app): remove legacy onboarding and permissions - #38

Open
Foxpace wants to merge 1 commit into
codex/sensorbox-refactor-24-phone-legacy-advancedfrom
codex/sensorbox-refactor-25-phone-legacy-onboarding
Open

refactor(app): remove legacy onboarding and permissions#38
Foxpace wants to merge 1 commit into
codex/sensorbox-refactor-24-phone-legacy-advancedfrom
codex/sensorbox-refactor-25-phone-legacy-onboarding

Conversation

@Foxpace

@Foxpace Foxpace commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Removes the legacy onboarding and permission UI after the Compose replacement is wired.

What was added

  • Removal of introduction, storage-folder, privacy-policy, and power-saver fragments.
  • Removal of custom permission handler and settings dialog classes.

How it works

The Compose onboarding flow reads requirement state from MainViewModel and launches platform permission or settings requests through typed effects. Completion is persisted through AppPreferences, eliminating fragment-specific permission callbacks and navigation.

Stack position

Layer 25 of 31 in the SensorBox refactor stack. Review this PR against its configured base to see only this layer.

Validation

  • Full stack: ./gradlew test — BUILD SUCCESSFUL (160 tasks)

@Foxpace Foxpace changed the title codex/sensorbox refactor 25 phone legacy onboarding refactor(app): remove legacy onboarding and permissions Aug 15, 2026
@Foxpace
Foxpace marked this pull request as ready for review August 15, 2026 21:51

Foxpace commented Aug 19, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #46, which targets master and shows the final current tree. Closing this stacked layer so review stays on the consolidated diff; this PR remains available as history.

@Foxpace Foxpace closed this Aug 19, 2026

Foxpace commented Aug 19, 2026

Copy link
Copy Markdown
Owner Author

Stack restored at the author's request. This PR is again part of the original 31-layer refactor chain. The architecture work continues as stacked PRs #47 through #54; consolidated PR #46 is superseded.

@Foxpace Foxpace reopened this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant