fix(tui): move Sigwinch behind unix build constraints — unbreaks windows CI (release gate) - #269
Merged
Merged
Conversation
PR #268 shipped TermEnv.Sigwinch using syscall.SIGWINCH with no build tag, which does not exist on windows: CI-Go windows-build/windows-cross and Release have been red since 74b3203 (same class as the 5d79ab0 release-gate lesson; #268 merged before its windows CI completed). Move the implementation into rawterm_unix.go (darwin||linux, already the termios home) and add a nil-channel stub in rawterm_other.go — the TermEnv contract (loop.go:111-114 'may be nil') already covers it: Run's resize select never fires and the poll path repaints. Verified: GOOS=windows go build ./... rc=0, go build rc=0, go vet clean, internal/tui suite green on darwin.
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TermEnv.Sigwinchusedsyscall.SIGWINCH(unix-only) with no build tag — PR feat(tui): FR-TUI-P polish + bugfixes (muted palette, hero, metric strip, SIGWINCH, attach hardening) #268 landed it and CI-Go windows-build/windows-cross + Release went red on main (74b3203, e506f1b).rawterm_unix.go(//go:build darwin || linux— already the termios home) and add a nil-channel stub inrawterm_other.go.TermEnvcontract explicitly allows nil (loop.go:111-114), andRun's resize handling already checkswinch != nil— no behavioral change on unix.Evidence
GOOS=windows go build ./...→ rc=0 (was:undefined: syscall.SIGWINCHat loopimpl.go:1092)go build ./...+go vet+go test ./internal/tui/ -count=1green on darwinCloses the windows leg of FR-GO-14's cross-compile gate (same failure class as the 5d79ab0 release-gate fix: cross-OS files always need constraints).