Repository navigation
fix: 随机口令看得见、能复制、创建后不丢失 - #11
Merged
Merged
Conversation
The random password went into a hidden password field (browsers forbid copying from it) and the field was cleared after creating the room, so the password was effectively lost. Now: - readable password: 5 groups of 4 from 31 unambiguous characters (~99 bits) - shown after generating, with a copy button and a show/hide toggle - kept on the result after creating, with its own copy button - show/hide on the room's password field too - copy falls back to select-and-copy where the Clipboard API is refused - monospace password fields that fit a 360 px phone Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PCUwNSXQdqfDSugmFo4qmM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
「随机生成口令」把口令填进了密码框:看不见,浏览器也不允许从密码框复制;房间创建完后口令框还会被清空,口令实际上就丢了。
修复
K7QM-3XRP-9DTA-HWVE-N4BC。字母表去掉了 I、L、O、0、1 这些容易看错的字符;强度约 99 位,随机数做了去偏处理。测试
新增
browser-tests/password-ui.mjs:全部单元测试、10 个浏览器测试和 Pages 测试通过。
Generated by Claude Code