Conversation
On macOS 27 the MenuBarExtra host window is 8pt taller than the SwiftUI root (a 4pt safe-area inset top and bottom), and the system paints its own rounded backing across the whole window. The panel stopped at the safe area, so that backing showed as a gray frame above and below the menu, and the panel's SwiftUI shadow was clipped at the window edge into a hard gray band. Fill the panel to the window edges with ignoresSafeArea(), drop the clipped SwiftUI shadow, and let the window server draw the native shadow, which follows the clear window's alpha shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LptEE4YbaWL55YwQRnTt74
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughOn macOS 26, the menu bar panel extends its fill and border through the host window’s safe-area insets. The panel no longer draws a SwiftUI shadow, and the host window’s native shadow is enabled. Other presentation branches are unchanged. ChangesMenu Bar Panel Appearance
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established, though macOS 26 appearance should receive follow-up validation. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| .overlay { | ||
| RoundedRectangle(cornerRadius: Self.macOS26PopoverCornerRadius, style: .continuous) | ||
| .stroke(Color(nsColor: .separatorColor).opacity(0.7), lineWidth: 1) | ||
| .ignoresSafeArea() |
There was a problem hiding this comment.
Knowledge Base Used: Onboarding and menu bar
This branch has not been deployed
1 participant
Summary
On macOS 27 the menu bar menu shows a gray frame above and below the panel.
Cause (from a view-hierarchy dump of the live
MenuBarExtraWindow): the host window is 340×272 while the SwiftUI root is 340×264, a 4pt safe-area inset top and bottom. The system paints its own rounded backing across the whole window. Our panel stopped at the safe area, so that backing showed around it, and the panel's SwiftUI.shadowwas clipped at the window edge into a hard gray band.Fix (
MenuBarView.swift, macOS 26+ path only):.ignoresSafeArea(), so they cover the full window.Test plan
Cotabby Devbuild on macOS 27.0.1: the frame is gone, confirmed by eye.🤖 Generated with Claude Code
https://claude.ai/code/session_01LptEE4YbaWL55YwQRnTt74
Summary by CodeRabbit
The PR appears safe to merge after the planned macOS 26 visual check confirms the double outline has not returned.
Summary
The PR extends the macOS 26+ menu panel fill and outline through the window’s safe area and replaces the clipped SwiftUI shadow with a native window shadow.
Reviews (1) · Last reviewed commit: "Remove the gray frame around the menu ba..."