Skip to content

NEWS: complete the changes since 1.2; keep exception messages in the error column - #100

Merged
yannrichet merged 1 commit into
mainfrom
claude/fz-docs-skills-review-8xkpgw
Oct 1, 2026
Merged

yannrichet merged 1 commit into
mainfrom
claude/fz-docs-skills-review-8xkpgw

Conversation

@yannrichet

Copy link
Copy Markdown
Member

Pull Request

Description

Review of NEWS.md (Unreleased) against the 52 commits between tag 1.2 and main, plus checks of the public API (__all__ unchanged), new environment variables, pyproject.toml and the plugin manifests. Fills the gaps, removes two contradictions, and fixes one small defect found on the way.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • Test addition/modification

Changes Made

NEWS.md

  • New "Upgrading from 1.2: behavior changes at a glance" at the top of Unreleased: the behavior changes were scattered over 8 sections.
  • Missing entries added:
    • fzo() decodes percent-encoded case directory names back when rebuilding variable columns (9d73492);
    • an unexpected exception in one case no longer aborts a campaign run sequentially (one case or one calculator), the case gets status="error" (9d73492);
    • SSH/SLURM security warnings de-duplicated per host and message (9d73492);
    • Claude Code plugin / Agent Skill changes (skills/fz/ touched by 8 commits), with a reminder that .claude-plugin/*.json still say 1.2.0 and must be bumped at release.
  • Contradictions fixed:
    • "Breaking changes" said Python 3.14 was not declared, "Project metadata" said it was; pyproject.toml declares 3.9–3.14 (CI: Windows 3.9 excluded);
    • the original fz-mcp entry said restricted mode "refuses to start", superseded by the P0-7 entry.
  • Not added (no user-visible effect): CI-only commits (rpy2 install, coverage aggregation), tests-only commits, removal of the dead duplicate CalculatorManager, the staged then removed contrib/fz-Simulate.

Code (fz/helpers.py)

  • When run_single_case raises, run_cases_parallel stored the message under error_message, which the results table does not read: the error column stayed empty. Both the sequential and parallel paths now also set error (Unexpected error: ...). error_message is kept.

Testing Performed

Automated Tests

  • New test_case_exception_is_reported_in_error_column (sequential and parallel): fails on main, passes here
  • tests/test_usability_fixes.py, test_skill_static.py, test_docs_consistency.py, test_readme_paths.py, test_readme_structure.py, test_parallel_simple.py, test_robust_parallel.py: 38 passed
  • Full suite not re-run (two-line change in an exception handler)

🤖 Generated with Claude Code

https://claude.ai/code/session_012GxLbauyVHBQPCeSow8hdh


Generated by Claude Code

NEWS (Unreleased), checked against the 52 commits since tag 1.2:
- add an 'Upgrading from 1.2' summary of all behavior changes
- add missing entries: fzo decodes percent-encoded case names, a case
  raising an unexpected exception no longer aborts a sequential campaign,
  per-message de-duplication of SSH/SLURM warnings, Claude Code plugin and
  skill changes (manifests still at 1.2.0)
- fix contradictions: Python 3.14 classifier (declared), fz-mcp restricted
  mode (superseded by P0-7)

Code: the exception path of run_cases_parallel stored the message under
'error_message', which the results table does not read; it now also sets
'error' (sequential and parallel paths), with a test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012GxLbauyVHBQPCeSow8hdh
yannrichet pushed a commit to Funz/fz.github.io that referenced this pull request Oct 1, 2026
@yannrichet
yannrichet merged commit 17f65e2 into main Oct 1, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants