Repository navigation
Bump Fantomas to 8.1.0 - #95
Merged
Merged
Conversation
Smaug123
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the Fantomas dotnet tool from 7.0.6 to 8.1.0 (upgrade guide).
Changes
net10.0, so thecheck-formatjob now sets up the .NET 10.0.x SDK. The other jobs andglobal.jsonare unchanged.hooks/pre-pushuses the newfantomas check .verb instead of the--checkflag.Important
This PR does not touch
.git-blame-ignore-revs. That file lists commits by hash, and this repo only allows squash merges, which give the merged commit a new hash. So, as with the earlier Fantomas format commit (#4), the hash goes in a follow-up PR: once this PR is squash-merged, a small PR adds the hash of the squashed commit onmainto.git-blame-ignore-revs. Until then,git blameshows this PR's formatting changes.Formatting changes
Both changes come from one v8 rule. The
fsharp_space_before_lowercase_invocationandfsharp_space_before_uppercase_invocationsettings put a space between a function and its parenthesized argument,f (x). In v8 they only do that when the function is a plain name such asList.maporFoo.Bar. A call with explicit type arguments, such asTypeList.cons<'t, 'ts>, now keeps its argument against the>:The rule comes from the F# style guide discussion in fsharp/fslang-design#648 ("Extra space in fluent code"). It was agreed there that only a plain name keeps the space before its argument. Anything else in front of the parenthesis (a call, an index, or type arguments as here) keeps the parenthesis tight. Fantomas implemented this in fsprojects/fantomas#3425 and describes it in Formatting chain expressions.