fix(desktop): validate and atomically persist main window state - #2973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the window-state plugin with desktop-owned geometry validation and atomic persistence.
.window-state.jsonformat and unknown fields.Type and Areas
Type: Bug fix
Areas: Desktop/Tauri, dependencies, regression tests, developer documentation
Motivation / Impact
Invalid saved dimensions, such as 65519 × 65526, can restore the main window at an unusable size. The previous plugin could also overwrite repaired state with stale cached data on exit.
The desktop now validates geometry against monitor bounds and scaling, restores usable defaults when necessary, and atomically saves validated snapshots.
Verification
rustfmt --check --edition 2021 src/apps/desktop/src/tray.rs— passed after conflict resolution.git diff --checkandgit diff --cached --check— passed.pnpm exec vitest run --config $windowTestConfig src/app/startup/startupPerformanceContract.test.tsThe temporary configuration contained
export default { test: { environment: "node" } };.pnpm --dir src/web-ui run test:run src/app/startup/startupPerformanceContract.test.ts— blocked by the missing@xterm/headless/lib-headless/xterm-headless.mjsdependency file.cargo test -p openbitfun-desktop --lib window_state_support::tests— compiled before rebase, but the test executable could not start (0xc0000139,STATUS_ENTRYPOINT_NOT_FOUND).pnpm run check:core-boundaries— blocked by a dangling HarmonyOSlibbitfun_crypto.solink.Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised.
Reviewer Notes
Checklist