Repository navigation
Conversation
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
…ansport Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
…acy-playback-controls Signed-off-by: Stefan Ovezea <sovezea@gmail.com> # Conflicts: # rust-modules/plex/src/plex/timeline.rs # rust-modules/screens/src/player/mod.rs # rust-modules/screens/src/registry.rs # rust-modules/src/app/playback.rs # tests/fixtures/replay/1-boot-home-chip-grid/manifest.json # tests/fixtures/replay/1-boot-home-chip-grid/rec-0000.jsonl # tests/fixtures/replay/12-filmography-detail-return/manifest.json # tests/fixtures/replay/12-filmography-detail-return/rec-0000.jsonl # tests/fixtures/replay/6-settings-family/manifest.json # tests/fixtures/replay/6-settings-family/rec-0000.jsonl
Signed-off-by: Stefan Ovezea <sovezea@gmail.com>
The maintainer review asked for no toggle on the episode buttons, so the "Previous/Next buttons" preference is removed end to end: the session field and setting row, the live cell, the Settings picker, its locale strings in every shard, the boot scenario and the docs. The pair now shows whenever an episode has a neighbour in its PlayQueue. Instant D-pad seeking stays as the one opt-in playback option. Also drops the leftover "legacy"/"modern" wording and the empty ScrubPress::Row arm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xn4z8v7ojwK4Xm9cci5Qon
Behaviour-preserving cleanups from a reuse/simplification/efficiency review of the branch: - delete the now-uncalled request_play_up_next and disc_hit_rect; the show-title rule lives once in request_play_queue_item - InstantDpadSeeking is written like DeckPress (LADDER, soft deserializer beside its siblings) instead of a one-use macro - Controls::pair is derived; Controls::now skips the queue lookup and the playhead read for non-episodes - the player row maps its actions straight to overlays; one disc stack builder; one row_index decoder; end_jump_gesture/drop_transport_tap replace the copied resets - TransportButton rules out a focused disabled face once, at draw time - queue_navigation shares current_index and stores fetched windows without copying CI fixes on the tree merged with main: the focus probe prints the episode-pair keys for every row occupant, and the per-profile and Settings picker counts match the merged settings list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xn4z8v7ojwK4Xm9cci5Qon
Owner
Author
|
Closing: these same commits were pushed to #921's branch, and #921 was squash-merged as 2d238e7 with @stefan-ovezea credited. This PR is no longer needed. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is #921 by @stefan-ovezea, finished on a branch in this repository so it can merge. The work is theirs; the squash credits them as co-author. Their commits are kept unchanged on this branch, followed by two finishing commits and a merge of
main.Behaviour
main.SeekBurst), so landing on an earlier keyframe doesn't swallow the travel.[Previous][Next], a wider gap, then[Subtitles][Audio][More]. They show whenever an episode has a neighbour in its PlayQueue. There is no setting for them.GET /playQueues/{id}), so the earlier rows survive moving on.Key::Otherrather than as arrows. Outside playback they do nothing, asui::constsdocuments for transport keys. The trailer already handles them in that form.Finishing commits on top of #921
4eb388f8removes the "Previous/Next buttons" setting end to end, as the review asked: the pref, its Settings row, its locale strings, the boot scenario and the docs. It also tidies leftover "legacy"/"modern" naming.mainatdb75bbbf: ru: the five keys the catalogue is missing (Play Version, playback speed) #1029 already adds the five Russian keys this branch had added itself, andmain's shorter "Скорость" label is kept. The branch's longer string overflowed the More menu's fits-in-every-language tests.0a6d418dapplies behaviour-preserving simplifications and fixes Add FF/REW tap seeking and independent playback navigation options #921's CI failures.request_play_up_nextanddisc_hit_rect;InstantDpadSeekingis now declared the same way asDeckPress;Controls::pairis derived, and non-episodes skip the per-frame queue lookup;TransportButtonrules out a focused disabled face in one place, at draw time;Verification
Run on the committed tree
0a6d418din a Linux container that runs as root:make lint(clippy) is clean, andmake check-nodefandci/check-module-layers.pypass.make checkunit stage, for the crates this PR touches:plx_screens:test result: ok. 1720 passed; 0 failedplx_appkit:test result: ok. 350 passed; 0 failedplx_ui:test result: ok. 1390 passed; 0 failedEvery other failure is environmental:
plx_plex: 20persistence_tests(they also fail on Add FF/REW tap seeking and independent playback navigation options #921's untouched head here)plx_media: 13prefs_characterisation/prefs_doortests plus 1curlioconnect-timeout testplx_telemetry: 2 persistence testsThese tests make files or folders unwritable to force failures, which root bypasses, or depend on network timing here. They don't touch this PR's code. Because the unit stage failed,
make checkstopped there and its later stages did not run locally; this PR's CI, which does not run as root, covers them.The ARM cross-build and the simulator builds were not run locally; CI runs them.
Nothing has been exercised on an LG TV.
Notes
playback_navigationshards (be, de, es, fr, hu, it, pt, ru) are AI-drafted and have no native-speaker review.Generated by Claude Code