Repository navigation
Also available: a show or season copy shows no runtime (#814) - #897
Merged
Merged
Conversation
…minal duration is no episode's (#814) The cross-server projection is now a pure fn (alt_copies_from), and one predicate (metadata::has_runtime) decides leaf vs container for both the rows and About's Runtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GLinnik21
enabled auto-merge (squash)
October 22, 2026 12:35
# Conflicts: # rust-modules/screens/src/detail/about.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #814
What was wrong
Both screenshots in the report are show pages. On a show page, "Also available" looks up
plex://show/…on each server, and each row printed the show container'sMetadata.duration. That value is the metadata agent's nominal per-episode runtime: a rounded figure that differs per server and matches no episode. So the rows read "49 min" / "1 h 40" beside a hero showing the next episode's real 45 / 48 min.Measured on a real PMS with GET requests only:
Metadata.durationequals/library/metadata/<rk>and everyMedia.duration.About's "Runtime" row had the same flaw on show and season pages.
Fix
metadata::has_runtime(kind): false for show, season, artist, album, collection and playlist.alt_copies_from, the projection extracted fromresolve_alt_sourcesso it can be tested, gives a container copy no runtime. The row's existing empty-slot rule leaves the sub-line to the owner alone.Verification
alt_runtime_tests: 3 tests. Before the fix:FAILED. 1 passed; 2 failed. After:ok. 3 passed.a_show_or_season_has_no_runtime_row_and_a_leaf_keeps_its_own:FAILED, thenok.make checkpasses, andmake check-nodefis clean. No capture or replay anchor changed.🤖 Generated with Claude Code