Repository navigation
docs(architecture): split unreadable §3 infra diagram into master + 3 focus - #89
Merged
Merged
Conversation
Add a root Makefile exposing four lightweight targets for the soutenance demo gestures: trigger (Scheduler), last-run, logs, fresh. Commands are kept deliberately light (--limit=1, table format) for live readability, distinct from the richer diagnostic variants in docs/runbook.md. The runbook gains a cross-reference note pointing to make for quick checks while keeping all its diagnostic commands (jq triggerName, raw/marts asymmetry, Knative v1 paths) — no double source of truth, different intents. Refs: D114
… focus The single "Infrastructure et déploiement" diagram carried 7 orthogonal concerns (runtime + security + monitoring + IaC + CI/CD + storage + secrets, 18 edges half of them dashed and crossing), making it unreadable. Replace it with four readable views sharing the same runtime skeleton: - 3.1 nominal execution flow (Scheduler → ingestion → GCS → BQ → dbt → dashboard) - 3.2 focus security & identity (sa-ingestion / sa-dbt / Secret Manager) - 3.3 focus monitoring & robustness (2 alerts + assumed scheduler gap, D109) - 3.4 focus deployment (Terraform 6 modules + CI/CD) Existing "Points clés" prose preserved (still consistent). linkStyle added for edge visibility in dark mode.
ESNAULTQ
self-requested a review
June 2, 2026 07:14
ESNAULTQ
approved these changes
Jun 2, 2026
ESNAULTQ
left a comment
ESNAULTQ
left a comment
Collaborator
There was a problem hiding this comment.
Je t'autorise car je suis le grand validateur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Le diagramme « Infrastructure et déploiement » (§3 de
docs/architecture.md) était illisible : un seul plan portait 7 préoccupations orthogonales (runtime + sécurité + monitoring + IaC + CI/CD + storage + secrets), avec 18 arêtes dont la moitié pointillées qui se croisaient.Cette PR le décompose en quatre vues lisibles qui partagent le même squelette runtime — un lecteur reconnaît les mêmes nœuds (Job ingestion / Job dbt / BigQuery) d'un diagramme à l'autre.
Décisions techniques
linkStyle default stroke:#888ajouté — les arêtes étaient invisibles sur fond sombreChangements
docs/architecture.md§3 : remplacement dugraph TDdense par 4 blocsflowchart LR(§3.1 à §3.4). §1 et §2 inchangés.Validation
```
$ grep -c '### 3.' docs/architecture.md
4 # 4 sous-sections §3.1 à §3.4
$ grep -n 'graph TD' docs/architecture.md
17:graph TD # = §1 Acquisition (légitime, intact)
```
Diff : +119 / −66. Aucune ressource modifiée → pas d'impact infra. Pre-commit + Conventional Commit verts. Rendu Mermaid vérifié (GitHub + preview).
Décisions liées
Refs : D60 (SA distincts), D105/D106/D109 (monitoring + trou scheduler), D70 (CI/CD), D72/D108 (orchestration), D113 (env vars).