Repository navigation
docs(dbt): correct RGPD comments on stg_sirene (no masking, not exposed) - #93
Merged
Merged
Conversation
The header comment referenced a masking that is never applied, and the is_diffusion_partielle description claimed address columns are excluded from staging — both inaccurate against the SQL. stg_sirene is a terminal model: the FT × Sirene join was abandoned (D14-bis, SIRET absent from offers), so Sirene feeds no mart and its PII is never exposed downstream. Masking is therefore not required; the pii tags serve traceability (PII inventory, queryable via tag:pii) and the diffusion flag is captured but unused. Comments now state this honestly. No code or logic change — documentation only. dbt parse passes.
ESNAULTQ
self-requested a review
June 4, 2026 09:25
ESNAULTQ
approved these changes
Jun 4, 2026
GMartin-Data
added a commit
that referenced
this pull request
Jun 4, 2026
…93 (#95) Several node labels overflowed their boxes in LR flowcharts (text cropped at render): STG_FT, INT_ANA, FCT_OFF in the dbt lineage diagram, and GAP in the monitoring diagram. Split the long lines with extra <br/> — no text or meaning changed, only line-break points. Also correct STG_SI: "masquage RGPD" → "tags PII · non exposé", aligning the diagram with PR #93 (no masking is applied; Sirene is a terminal model, PII tagged for traceability but never exposed downstream — D14-bis).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
En préparant le Sujet 4 (gouvernance/RGPD) de l'exposé de soutenance, une relecture de
stg_sirene__etablissementsa révélé deux affirmations de documentation fausses au regard du SQL — exactement le type d'écart discours/code que le jury peut relever (brief l.95 : « questions sur n'importe quelle partie du code »).Le fond est rassurant :
stg_sireneest un modèle terminal. La jointure FT × Sirene ayant été abandonnée (D14-bis, SIRET absent à 100 % des offres), Sirene n'alimente aucun mart — vérifié : zéroref()vers un modèle Sirene dans le projet, etfct_offresne contient ni SIRET/SIREN ni dénomination Sirene. La PII Sirene n'est donc jamais exposée : pas de diffusion → masquage non requis (principe de minimisation RGPD). Restait à aligner les commentaires sur cette réalité.Changements
dbt/models/staging/sirene/_sirene__models.yml:pii) : précise que le tag sert la traçabilité (inventaire des PII, requêtable viatag:pii) et qu'aucun masquage n'est appliqué car le modèle n'est pas exposé. L'ancien texte renvoyait à un masquage inexistant.is_diffusion_partielle: supprime l'affirmation fausse « Les colonnes d'adresse détaillée sont exclues du staging » (le SQL n'exclut rien sur cette base). Reformulée en : flag de statut INSEE'P'capturé pour traçabilité, non exploité en aval.Aucun changement de code ou de logique — documentation uniquement. Les tags
pii(7 colonnes) et le filtre actifs (etatAdministratifEtablissement = 'A') restent inchangés.Validation
dbt parsepasse (YAML valide). Pre-commit : Conventional Commit ✅, ruff skipped (pas de.pytouché).Refs
stg_sireneest entériné : livrable technique conservé comme archive pour la soutenance (vestige assumé de la jointure abandonnée), il n'alimente volontairement aucun mart.contenu-slides.md, hors repo) sur « minimisation + non-exposition » plutôt que « masquage ».