Repository navigation
fix(infra): scope make logs to 7 days so demo events are visible (D114) - #96
Merged
Merged
Conversation
…114) `gcloud logging read` defaults to the last 24h. The pipeline runs weekly (Monday cron), so outside the day after a run the `logs` target returned nothing — the demo gesture proving the ingestion -> dbt orchestration showed an empty result. Add --freshness=7d to cover the latest weekly run. The filter itself was correct (ingestion_end / dbt_invoked events are present); only the implicit time window was too narrow. Comment moved above the recipe so make does not echo it before the output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Test des cibles read-only du Makefile démo (D114, hors
make trigger) à la veillede la soutenance. Trois cibles sur quatre se comportent comme attendu
(
help,last-run,fresh) ;make logsrenvoyait un résultat vide.make logsest le geste qui prouve l'enchaînement ingestion → dbt (orchestrationconditionnelle, D72/D108) — un résultat vide en démo ferait tomber cet argument.
Cause racine
gcloud logging readn'interroge que les dernières 24 h par défaut. Le pipelinetourne en hebdomadaire (cron lundi) : hors du lendemain d'un run, la fenêtre de 24 h
ne couvre plus aucun event. Le filtre était correct — les events
ingestion_end/dbt_invokedsont bien présents (vérifié avec--freshness=7d, la séquence remonte).Seule la fenêtre temporelle implicite était trop étroite.
Changement
Makefile— ciblelogs:--freshness=7d(couvre le dernier run hebdomadaire quoi qu'il arrive) ;makel'echo avantla sortie → bruit visuel en démo).
Validation
make logsaprès correction, sortie réelle (run du 2026-06-01) :L'enchaînement
ingestion_end→dbt_invokedest désormais visible. Les 3 autrescibles read-only (
help,last-run,fresh) ont été testées et se comportent commeattendu.
make triggernon testé (déclenche le pipeline, hors périmètre).Refs : D114 (Makefile démo), D72 / D108 (orchestration conditionnelle ingestion → dbt).