Repository navigation
fix(infra): make last-run/logs demo targets show what their help promises - #97
Merged
Merged
Conversation
The help text promised 'statut SUCCEEDED attendu' but the output columns (name, completionTime, creationTimestamp) carried no status field, so a successful run was indistinguishable from a failed one at a glance. Add the status.succeededCount column (rendered as SUCCEEDED_COUNT by gcloud) and align the help wording on the actual API field, since Cloud Run v2 exposes no literal SUCCEEDED enum on executions.
A nominal run emits one ingestion_end per source (7 sources) plus one dbt_invoked. With --limit=5 shared across both events, only 4 of the 7 ingestion_end lines surfaced, so 'make logs' failed to prove the full ingestion -> dbt chain it documents. Raise --limit to 10 (7 sources + dbt_invoked + margin) so the complete handoff is visible in a single demo command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
Les cibles de démo du
Makefile(D114) doivent prouver visuellement lebon déroulé du pipeline lors de la soutenance. Deux d'entre elles annonçaient
dans leur aide un comportement que leur sortie ne reflétait pas :
make last-runpromet « statut SUCCEEDED attendu » mais n'afficheaucune colonne de statut (
name,completionTime,creationTimestamp) —un run réussi était indistinguable d'un échec à l'écran.
make logsdocumente « Prouve l'enchaînement ingestion → dbt » mais--limit=5, partagé entre les eventsingestion_endetdbt_invoked,ne laissait voir que 4 des 7
ingestion_endd'un run nominal.Décisions techniques
last-runstatus.succeededCount(renduSUCCEEDED_COUNTpar gcloud). Cloud Run v2 (Knative) n'expose pas d'enum littéralSUCCEEDEDsur l'execution — le succès se lit viasucceededCountouconditions[type=Completed].succeededCountest le plus lisible entable().last-runsucceededCount=1 attendupour coller au vrai champ API plutôt qu'à un enum inexistant.logs--limit=10: 7 sources (ingestion_endémis une fois par source viamain.py) +dbt_invoked+ marge. Garde l'esprit « commande légère, une seule invocation » du Makefile.Changements
Makefile(last-run) : ajout colonnestatus.succeededCount+ aide alignée sursucceededCount=1.Makefile(logs) :--limit=5→--limit=10.Validation
make last-run— la colonneSUCCEEDED_COUNTrend le succès explicite :make logs— l'enchaînement complet est désormais visible (7ingestion_end+dbt_invoked) au lieu de 4 :grepconfirmant les 7 sources émettantingestion_end:Décisions liées
Refs : D114 (Makefile de démo).