fix(tokens): name the RWA assets after their on-chain symbol - #319
Merged
Merged
Conversation
The SDK rewrites a redemption phantom's symbol for display —
`TokensMeta.renameRedemptionPhantoms` turns it into `"${source} -> ${target}"`,
but only when it knows all three addresses. Until then the token reports what
its contract says, and that is the name an asset can always be found by. Read
off the RWA fork: `srpACRED_USDC`, `srpSTAC_USDC`, `mF-ONErdUSDC` — which is the
convention the repo started with, before `mf-onerdusdc.svg` was dropped as an
unused alias.
So the assets take the contract's spelling, and ui-kit maps the rewritten name
onto it. `mf_one.svg` becomes `mf-one.svg` for the same reason: mF-ONE's own
symbol carries a dash, the underscore was an artifact of the old resolver.
`medge->usdc.svg` goes: `medgerdusdc.svg` already holds that artwork byte for
byte, under the contract's name.
Checked against every symbol source at once — the mainnet SDK, the backend, and
the RWA and Securitize forks. `mGLOBAL` and `mGLOBAL -> USDC` have no artwork at
all; no rename reaches that one.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK rewrites a redemption phantom's symbol for display —
TokensMeta.renameRedemptionPhantomsturns it into"${source} -> ${target}", but only when it knows all three addresses. Until then the token reports what its contract says, and that is the name an asset can always be found by. Read off the RWA fork:srpACRED_USDC,srpSTAC_USDC,mF-ONErdUSDC— which is the convention the repo started with, beforemf-onerdusdc.svgwas dropped as an unused alias.So the assets take the contract's spelling, and ui-kit maps the rewritten name onto it.
mf_one.svgbecomesmf-one.svgfor the same reason: mF-ONE's own symbol carries a dash, the underscore was an artifact of the old resolver.medge->usdc.svggoes:medgerdusdc.svgalready holds that artwork byte for byte, under the contract's name.Checked against every symbol source at once — the mainnet SDK, the backend, and the RWA and Securitize forks.
mGLOBALandmGLOBAL -> USDChave no artwork at all; no rename reaches that one.