Fix restart float test and vcpkg Windows CI - #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two independent failures exposed by the current test matrix.
The
on_restart::sol_floatfixture left its output float unbounded even though the expected first solution assumes a lower bound of1.0. Restart initialization uses the variable lower bound when no previous solution exists, so the test printed Gecode’s minimum representable float. The output now uses the same1.0..3.0domain as the test input and restart variables.The Windows vcpkg job was pinned before microsoft/vcpkg#53437, where the GMP port still referenced an unavailable Autoconf 2.71 package. The workflow checkout, cache key, and manifest baseline now use vcpkg commit
37bb045f3c7a747d3e5d1c13b6fe6a0aec4b5d00. That baseline selects GMP6.3.0#5and its reachableautoconf2.71-2.71-4package. GMP intentionally remains on Autoconf 2.71 because its port documents broken dumpbin detection with 2.72.Validation:
FlatZinc::on_restart::sol_floatfailure on macOSgecode-testnativelyFlatZinc::on_restart::*tests passvcpkg.jsonand the workflow parse successfully