Repository navigation
Update Permission Policy Directives - #384
Merged
GeekInTheNorth merged 6 commits intoSep 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical issues remain with public API compatibility, directive migration behavior, and the packaged UI bundle.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 4
Open (4)
What changed in this PR
Updates the Permissions-Policy directive catalog, deprecation handling, migrations, UI, and test coverage.
Changes:
- Adds current directives and deprecation metadata.
- Migrates and imports renamed directives.
- Expands backend, UI, and Playwright tests.
| File | Summary |
|---|---|
ui-tests/tests/permissions-policy-directives.spec.ts |
Tests current and deprecated directives. |
ui-tests/helpers/reset.ts |
Seeds deprecated directive data. |
ui-tests/helpers/permissions-policy-page.ts |
Adds directive and scope assertions. |
ui-tests/helpers/permissions-policy-headers.ts |
Adds absence assertions. |
ui-tests/helpers/custom-headers-page.ts |
Improves scope synchronization. |
src/Stott.Security.Ui/src/PermissionsPolicy/PermissionsPolicyContainer.jsx |
Uses stable directive keys. |
src/Stott.Security.Ui/src/PermissionsPolicy/PermissionPolicyCard.jsx |
Displays deprecation badges. |
src/Stott.Security.Optimizely/Migrations/20260827120000_RenamePermissionPolicyDirectives.Designer.cs |
Adds migration metadata. |
src/Stott.Security.Optimizely/Migrations/20260827120000_RenamePermissionPolicyDirectives.cs |
Renames legacy directives. |
src/Stott.Security.Optimizely/Features/Tools/MigrationRepository.cs |
Resolves legacy names during imports. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/Service/PermissionPolicyService.cs |
Handles deprecated directive behavior. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/Repository/PermissionPolicyMapper.cs |
Maps directive metadata. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/PermissionPolicyDirective.cs |
Defines directive metadata. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/PermissionPolicyConstants.cs |
Adds and categorizes directives. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/Models/PermissionPolicyDirectiveModel.cs |
Carries directive metadata and deprecation state. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/Models/IPermissionPolicySettings.cs |
Removes unused imports. |
src/Stott.Security.Optimizely/Features/PermissionPolicy/Models/CompiledPermissionPolicy.cs |
Updates collection initialization. |
src/Stott.Security.Optimizely.Test/Stott.Security.Optimizely.Test.csproj |
Updates test dependencies. |
src/Stott.Security.Optimizely.Test/Features/Tools/MigrationRepositoryDataTests.cs |
Tests legacy-name imports. |
src/Stott.Security.Optimizely.Test/Features/PermissionPolicy/Services/PermissionPolicyServiceTests.cs |
Tests deprecated directive behavior. |
src/Stott.Security.Optimizely.Test/Features/PermissionPolicy/Services/PermissionPolicyServiceTestCases.cs |
Updates directive filter cases. |
src/Stott.Security.Optimizely.Test/Features/PermissionPolicy/PermissionPolicyConstantsTests.cs |
Tests directive catalog invariants. |
src/Stott.Security.Optimizely.Test/Features/PermissionPolicy/Models/PermissionPolicyDirectiveModelTests.cs |
Tests metadata mapping and serialization. |
Sample/OptimizelyTwelveTest/Startup.cs |
Adjusts sample startup configuration. |
Sample/OptimizelyTwelveTest/OptimizelyTwelveTest.csproj |
Updates sample dependencies. |
Sample/OptimizelyTwelveTest/Features/UiTest/ResetSystem.cs |
Seeds deprecated directives for UI tests. |
Files not reviewed (1)
- src/Stott.Security.Optimizely/Migrations/20260827120000_RenamePermissionPolicyDirectives.Designer.cs: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #379