Repository navigation
docs(privacy): say which servers the CPSR and MultiQC reports contact when opened - #494
3 commits merged into
Conversation
… when opened The privacy page left the CPSR (step 17) and MultiQC (step 28) reports as "not checked", so a reader could not tell whether opening them tells a server their IP address. Both were opened in a browser that blocked and logged every request to the internet: neither loads anything. Their external addresses are plain links. Bead: K010 Bead: K028
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…ivacy # Conflicts: # CHANGELOG.md
… test misses both reports
# Conflicts: # CHANGELOG.md
The rust job took 23 minutes on main (limit 30) and parity 19 (limit 20). The same trees on the geiresx fork ran past both limits, twice, so a docs-only PR (#494) could not get a green ci-ok. Raise rust to 45 and parity to 35: the limit is there to stop a hung job, not a slow one.
Problem
The privacy page lists what each HTML report loads from the internet when you open it. A report that loads a file tells that server your IP address. Two reports were left out: the page said "Not checked: the CPSR (step 17) and MultiQC (step 28) reports". A reader could not tell whether opening them contacts any server.
Fix
docs/why-local.md, section "Opening the reports", now has a dated bullet for each of the two reports and no "Not checked" line:CHANGELOG.mdgets one line. Docs only: no option, output or file name changes.Decision: the e2e address listing does not see these two reports (the test never builds a real CPSR report, and its MultiQC report is written in another job than the listing), so the PCGR 2.3.2 data bundle and VEP cache were not downloaded to build a CPSR report here. The CPSR evidence is the CPSR project's own example reports of versions 2.3.0 and 2.4.0, plus the report template inside the pinned image. Version 2.3.0 is the CPSR that the pinned PCGR 2.3.2 image runs. The doc says this.
How it was checked
Each report was opened in headless Chromium with every request that is not
file:,data:orblob:blocked and logged. The script clicks every tab and scrolls the whole page so lazy content renders.maxcdn.bootstrapcdn.com,code.jquery.com,assets-cdn.github.com). This shows the logger catches loads.quay.io/biocontainers/multiqc:1.35--pyhdfd78af_2, the pinned image), run with the step's options (-f --no-version-check --no-ai, the step's title) on a samtools flagstat file, in a container with no network: 0 requests.Static scan of the same files for
srcorhrefonscript,link,img,iframe, and for@importorurl(http...)in CSS:http(s)address and no CSS imports one. Everyhttp(s)address is an<a href>link.img src="https://assets-cdn.github.com/...octocat.png". It sits inside a JavaScript string (the emoji table of the bundled Markdown converter), not in the page, and the browser run shows it is never requested.ghcr.io/sigven/pcgr:2.3.2image (cpsrR package 2.3.0,templates/cpsr_report.qmd) setsembed-resources: true. Itscpsr.cssuses onlydata:URLs, and no template file has ascript,link,imgoriframetag with anhttp(s)address.CI on this head runs the doc link check and the docs build.
Beads
K010, K028
Summary by CodeRabbit