Skip to content

chore(beads): drop a MacBook-only lefthook path from the committed hook - #176

Merged
GeiserX merged 1 commit into
mainfrom
chore/beads-hook-local-path
Oct 3, 2026
Merged

GeiserX merged 1 commit into
mainfrom
chore/beads-hook-local-path

Conversation

@GeiserX

@GeiserX GeiserX commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

The committed .beads/hooks/prepare-commit-msg carried a fallback that ran lefthook from a path under one person's home directory on one machine. That path exists nowhere else, so the branch never fired for anyone but its author, and a public repo should not name a home directory.

The fix removes those three lines. The hook still finds lefthook on PATH, in node_modules, or through the package-manager runners, exactly as before. No other hook changes.

Summary by CodeRabbit

  • Chores
    • Commit preparation now uses Lefthook when it is available through the standard command lookup and no explicit executable is configured. Existing repository and package-manager fallbacks remain available. This removes reliance on a platform-specific Lefthook executable.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: GeiserX/Pumperly/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c2473b3a-b55b-4c74-bcbb-c622b41786e5
📥 Commits

Reviewing files that changed from the base of the PR and between c60e4ae and 03092b3.

📒 Files selected for processing (1)
  • .beads/hooks/prepare-commit-msg
💤 Files with no reviewable changes (1)
  • .beads/hooks/prepare-commit-msg

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The prepare-commit-msg hook removes a hard-coded macOS ARM64 Lefthook binary check and invocation. When LEFTHOOK_BIN is unset, it uses lefthook from command lookup if available; otherwise, it continues to the existing fallback search.

Changes

Lefthook command resolution

Layer / File(s) Summary
Hook command resolution
.beads/hooks/prepare-commit-msg
The hook no longer checks or invokes the hard-coded binary path. It uses lefthook from command lookup when available, or continues to the existing fallback search.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 03092

The hook retains its supported Lefthook lookup paths and is ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: removing the MacBook-specific Lefthook path from the committed hook.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX
GeiserX merged commit 1b34cd5 into main Oct 3, 2026
4 checks passed
@GeiserX
GeiserX deleted the chore/beads-hook-local-path branch October 3, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant