fix(drawable): Prevent crash from null tint envelope in OverlordTank/TruckDraw - #587
Open
sentry[bot] wants to merge 1 commit into
Open
fix(drawable): Prevent crash from null tint envelope in OverlordTank/TruckDraw#587sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses CLIENT-1RX by adding null checks for the result of
getDrawable()->getColorTintEnvelope()before dereferencing it inW3DOverlordTankDraw::doDrawModuleandW3DOverlordTruckDraw::doDrawModule.The previous implementation would crash with an
EXCEPTION_ACCESS_VIOLATION_READifgetColorTintEnvelope()returned null, as it was immediately dereferenced to pass tosetColorTintEnvelope.The fix mirrors the safe pattern already present in
W3DOverlordAircraftDraw, ensuring that the tint envelope is only applied if it is non-null.Fixes CLIENT-1RX
This PR was automatically generated by Sentry. You can adjust this setting at any time.