fix(rendering): Prevent crash on null texture surface creation in Build_Textures - #588
Open
sentry[bot] wants to merge 1 commit into
Open
fix(rendering): Prevent crash on null texture surface creation in Build_Textures#588sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a crash in
Render2DSentenceClass::Build_Textures(CLIENT-1C6) that occurred whenTextureClass::Get_Surface_Level()returned an invalidSurfaceClass(i.e., one whose underlying D3D surface was null). The issue manifested as anEXCEPTION_ACCESS_VIOLATION_READ / 0xcwhen attempting to dereference the invalid surface.The fix introduces two null/validity checks within the
Build_Texturesloop:new_texture == nullptrafterW3DNEW TextureClass(...)to handle allocation failures.texture_surface == nullptr || !texture_surface->Is_Valid()afternew_texture->Get_Surface_Level()to ensure the D3D surface was successfully created.If either check fails, the relevant objects are released, and the loop continues to the next pending surface, preventing the crash and aligning with existing defensive programming patterns in the codebase.
Fixes CLIENT-1C6
This PR was automatically generated by Sentry. You can adjust this setting at any time.