batch: Recognize the +W modifier in -T (case-sensitive lookup bug) - #9141
Open
Esteban82 wants to merge 1 commit into
Open
batch: Recognize the +W modifier in -T (case-sensitive lookup bug)#9141Esteban82 wants to merge 1 commit into
Esteban82 wants to merge 1 commit into
Conversation
The modifier separator list passed to gmt_first_modifier/gmt_getmodopt
in the -T parsing of batch was "psw" (all lowercase). Since strchr()
is case-sensitive, the documented +W modifier (force TAB-only word
splitting of the timefile's trailing text) could never match:
- "-T<file>+W" alone: the modifier was silently dropped with a
warning, and "+W" ended up appended to the stored filename, so the
timefile was never found ("No jobs specified! - exiting.").
- "-T<file>+p<n>+W" combined: parsing hit a hard
"Unrecognized modifier +W" error.
Add 'W' to both separator strings so it is recognized alongside
p/s/w, matching what batch.rst already documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
batch
's-T option documents+Was a modifier but this doesn't work. I got this errorERROR: No jobs specified! - exiting.Fix: add
Wto both separator strings ("psw"→"pswW") so it's recognized on par with the other modifiers, matching the documented behavior.Tested with:
Without this fix:
ERROR: No jobs specified! - exiting.With this fix:
WORD0=AlphaWord / WORD1=BetaWordAssisted-by: Claude Sonnet 5 (extra effort)