Figure.choropleth: Validate the input data type and the column name - #4852
Open
seisman wants to merge 1 commit into
Open
Figure.choropleth: Validate the input data type and the column name#4852seisman wants to merge 1 commit into
seisman wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds early validation to Figure.choropleth to prevent invalid inputs and column names from causing segmentation faults.
Changes:
- Validates supported data types and column names.
- Excludes geometry columns from attribute validation.
- Adds regression tests for invalid inputs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
pygmt/src/choropleth.py |
Adds input and column validation; attribute-less geo-like objects still require column validation handling. |
pygmt/tests/test_choropleth.py |
Adds tests for invalid columns and data types. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown by the example below, passing an invalid
columnleads to a segmentation fault:This PR checks the input data type and also check if the specified
columnexists in the geo-like objects.