Repository navigation
row 194: migrate to the sealed-ABI dual forms (expand-then-contract) - #36
Closed
MattJackson wants to merge 2 commits into
Closed
MattJackson wants to merge 2 commits into
MattJackson wants to merge 2 commits into
Conversation
Contributor
Author
|
Folded into #34 (door-root), which now carries this migration's dual forms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 194 MIGRATE step: moves the inventoried sites to the dual-compatible form, compiling against busbar dev + #1478 and against #1471. Based on dev; the open A1 and advisory PRs are untouched.
Sites migrated: 15 (src 8: NONE, NEEDS, TAIL, STATEMENT, the
instances()reads,batch(),phase(), MACRO_DOOR already re-exported; tests 7: length accessors,unsafe { Host::from_raw(&tables) }under#[allow(unsafe_code)]on that one test fn,MACRO_DOORin the conformance suite).instances()already read the lend through the safe accessor on dev; only the field picks changed.CONTRACT-TIME sites left: none in hand-written files.
Rendered files left alone (busbar-release template PR migrates and re-renders them):
DoorFnanddoors()(:55, :80-86),LinkedRow::of(door)(:187),Blob { .. BLOB_ABSENT .. }(:211-216)Pin: busbar dev, unchanged. CI is red until #1478 lands on dev (the new names are missing there); after that the pin moves to the dev commit that contains #1478.