Repository navigation
row 163: the predev→dev oracle check keeps its candidate recording as an artifact (outputs:) - #1036
Merged
Merged
Conversation
… artifact (outputs:, ModernCI 0.4.1103)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 163 lane follow-up to #909. One line of config, nothing else.
What: the
oraclecheck in.ci/predev.yamldeclaresoutputs: [target/oracle/recordings/candidate]. ModernCI (0.4.1103) keeps a check's declared outputs as artifacts, so the candidate recording the judge replayed against the 1.5.5 golden can be fetched withmodernci call artifact. A red cell can then be read from the exact bytes judged, with no rerun. The golden, the pin and every check command are unchanged.Why: coordinator request after #909 landed (ModernCI keeps check artifacts declared under
outputs:).RED-able test:
xtask/tests/infra.rs::every_gate_the_modernci_branch_files_call_is_registeredstill reads this file.branch_file_check: ok:true.Ledger rows: none.