Skip to content

Delete E5-core-small-crates: dead helpers and duplicate tests in core-admin, core-connector, core-oauth2, kernel crates - #1670

Merged
MattJackson merged 1 commit into
devfrom
del-e5-core-small-crates
Oct 26, 2026
Merged

MattJackson merged 1 commit into
devfrom
del-e5-core-small-crates

Conversation

@MattJackson

Copy link
Copy Markdown
Collaborator

Deletion batch E5-core-small-crates (core-admin, core-connector, core-oauth2, kernel-audit/egress/identity/ledger/wal). 48 of 56 items deleted, 8 skipped. No file touched by the sequencing PRs (#1659, #1656-1658, #1651, #1660, #1663, #1650, #1372, #1485).

production LOC (loc-tool): 251675 -> 251522

Deleted

  • core-admin: duplicate tests (verbs table count, idempotency no-journal, openapi row count, required_scope_mutations_are_full, one-time placeholder debug; its nonce assert folded into the first test), orphaned doc in restart.rs, FakeStore (now RecordingStore), duplicate hook() fixture (shared from service_tests), liveness probe loop (now spawn_liveness_probe), admit_recovery_verb (callers use admit), VersionLog::new (derive Default), usage_read_is_linear.rs include_str scan.
  • core-connector: Carried::is_shut, Bridge::stopped, Guard::judge_answer_as, HostIo::shut_write, ServerTls::alpn/security/accept, StdServerSession::refusal, TokioServerSession, need_client_config (plus its assertions in the client identity test), localhost_cert x2 and private_ca copy (now over test_support::private_ca), hostio worker() (use support::worker).
  • core-oauth2: read_login_cookie, parse_form_urlencoded, _State alias and AppHandle import, fapi2 enc() (uses flow_tests::encode_component).
  • kernel-audit: HeadHistory::sample_seconds, frozen-tags Debug test, derived_secret include_str scan (the ring-agreement assert stays).
  • kernel-egress: allocation census test and WeightedFloor::tracked, two duplicate net_tests, ERR_NET_TRANSPORT and ERR_DEGRADED_NON2XX.
  • kernel-identity: AuthChain::has_no_modules (tests use chain_names().is_empty()), OrderRecordingVerifier tests, chain Debug test, duplicate admin verdict test.
  • kernel-ledger: digest::sha256_hex (the FIPS-vector test keeps a local hex helper), duplicate tier-rounding / negative-fee tests (their unique assertions folded into posting_tests / derive_tests), rate.rs include_str check.
  • kernel-wal: MAX_RECORD_BYTES (layout test now pins busbar_contract::MAX_RECORD_BYTES), segment_dir_sync.rs test moved into dir_fsync.rs reusing its Scratch.

Skipped

  • framer Established.peer_key_pin/client_identity: set in compose.rs and read in lib.rs, not dead.
  • datagram_tests STUN helpers: differ from dtls/tests.rs (txid and creds signatures); a shared module is a new abstraction.
  • process_tests Table: not identical to name_dial_tests Table (30 ms sleep).
  • identity operator::install_row: used by busbar-kernel test_support.
  • ledger History::opening: ~70 test callers across crates including integration tests.
  • ledger rollup sum_spend/budget_remaining: used by core-admin service_operations.
  • ledger digest::sha256_of: used by busbar-kernel signing.rs and host_services.rs.
  • ledger legacy::RecordingRows: used by dozens of tests in busbar and busbar-kernel.
  • ERR_NET_CONNECT / ERR_NET_TIMEOUT (part of the upstream.rs item): used via proxy re-export in telemetry.

Local: cargo fmt, workspace check and clippy --all-targets -D warnings green; unit tests of every touched crate pass (connector needs --features busbar-contract/test-seal; its integration tests were not green in my sandbox and are left to CI).

…es in core-admin, core-connector, core-oauth2 and small kernel crates
@MattJackson
MattJackson merged commit 44169f6 into dev Oct 26, 2026
1 check was pending
@MattJackson
MattJackson deleted the del-e5-core-small-crates branch October 26, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant