Repository navigation
Delete E5-core-small-crates: dead helpers and duplicate tests in core-admin, core-connector, core-oauth2, kernel crates - #1670
Merged
Conversation
…es in core-admin, core-connector, core-oauth2 and small kernel crates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletion batch E5-core-small-crates (core-admin, core-connector, core-oauth2, kernel-audit/egress/identity/ledger/wal). 48 of 56 items deleted, 8 skipped. No file touched by the sequencing PRs (#1659, #1656-1658, #1651, #1660, #1663, #1650, #1372, #1485).
production LOC (loc-tool): 251675 -> 251522
Deleted
Skipped
Local: cargo fmt, workspace check and clippy --all-targets -D warnings green; unit tests of every touched crate pass (connector needs --features busbar-contract/test-seal; its integration tests were not green in my sandbox and are left to CI).