Repository navigation
Delete E2-kernel-collapse: busbar-kernel duplicates and overbuilt helpers - #1672
Merged
Merged
Conversation
…and helpers onto one implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch E2-kernel-collapse: busbar-kernel duplicates and overbuilt code, collapsed onto one surviving implementation. Behaviour is unchanged: no production logic moved, and no assertion was weakened or skipped.
Deleted / collapsed (35 items)
Production
hooks/taps.rs: the privateADMISSION_DENIED_TOTALcopy is gone; the tap gate now usescrate::snapshot::ADMISSION_DENIED_TOTAL(same string). The tap-dropped name stays in taps.rs, because snapshot/mod.rs records that it moved there on purpose.host_services.rstrust_sight: the inlineSight→TRUST_*match is nowsight_code(sight).Test fixtures and harness
audit/tests/auditlog_tests.rs: the frozen AD_1/AD_2 and LEGACY_1/LEGACY_2 bytes now come fromboot_verify_golden'sAD_1/AD_2(byte-identical; the consts becamepub(in crate::audit)).audit/tests/auditlog_tests.rsandjournal_tests.rs: the duplicatedDiagCapturelayer is now onetest_support::warn_capture::DiagCapture.auth/tests/dpop_tests.rs:stats_onandexchangedare now oneserved(method, path, headers, authorization_server)harness.config/tests/config_consolidation_tests.rs:c_mutable_with_the_overlay_explicitly_disabled_refusesis deleted.overlay_read_only_tests::e_…_is_still_a_boot_refusalasserts the same thing, more strictly.config/tests/linked_secret_hardening_tests.rs:resolve_linked_env_genuinely_unset_still_reports_unsetis deleted; it had the same assertions asresolve_linked_env_unset_variable_is_an_error.config/tests/secret_tests.rs:env_module_resolves_and_fails_closed,file_module_resolves_and_fails_closed,unknown_module_fails_closedandmalformed_builtin_refs_error_preciselyare deleted.linked_secret_hardening_testsandresolver_testsalready cover them.host_work/tests/handle_engine_tests.rs:an_idle_active_handle_stays_active_through_the_next_sweepis deleted, becausea_sweep_never_transitions_an_active_handle_however_long_it_idlescovers all of it.test_support/ranking_double.rs:RankingAxis::openandOpen::opennow share onestrategy_ofparse.tests/host_services_tests.rs:verdict_now,Memandcallerare now the one copy, shared withhost_stage_tests,host_chains_tests,host_verify_testsandhost_work_tests.tests/members/audit/{amend,digest_framing,journal,record,sign,subject_decoder}_tests.rs: the sixtoken()helpers are replaced bytest_support::tokens::pass::<AuditStep>().break_reporting_testsuses it too.tests/members/audit/record_tests.rs: theUnwrapErrOrElsetrait is gone; the call is now.err().unwrap_or_else(|| panic!(..)).route_tokeninbreaker/breaker_unit_tests.rs,egress/breaker_adapter_tests.rsandegress/route/harness.rs: replaced bytest_support::tokens::pass::<Route>().egress/route/walk_tests.rs:route_async, which repeated the attempt loop ofNode::route_with, is gone. That loop is nowNode::route_on(egress, pool, before);route_withandroute_overboth call it.ledger/cost/fixtures.rs:usageandestimated_usagenow build their lines withlines().ledger/cost/identity_tests.rs: theSeqLCG is replaced byledger::fixtures::Rng(the same constants, and the seed is already odd).wal/poison_tests.rs:a_store_that_refuses_an_on_disk_batch_does_not_fail_the_commitis deleted, becausean_on_disk_batch_the_store_refused_is_offered_again…covers it. TheRefusesstubs andjournal_chain_tests::RefusingShipperare now onewal::fixtures::RefusingShipper.tests/support/plane_driver_close_cases.rs: theNobodystub is deleted; this file now useshook_cases::Nobody.tests/support/plane_driver_hook_cases.rs:GatedRewritesandGatedGatesare now oneGatedBinder { gates, rewrites }.Skipped (24 items)
store/in_memoryreset_swrr_for: the forced edits touchstore/tests/tests.rs(C12: delete tests that prove internal seams, status rows or censuses #1657) andstore/vocab.rs(D2: drain plane_driver/serve.rs::TABLES — the generation carries its admin table (stacked on #1482) #1485). Waits for those PRs.audit/stream_registryDecodeenum: it is constructed inaudit/auditlog.rs, which C5: delete the legacy dual paths; keep the 1.5.5 migrate and read-back paths #1658 changes. Waits for C5: delete the legacy dual paths; keep the 1.5.5 migrate and read-back paths #1658.breaker::status_class_from_str: the forced edits are inconfig/mod.rsandconfig_validate/mod.rs(D2: drain plane_driver/serve.rs::TABLES — the generation carries its admin table (stacked on #1482) #1485).config/auth.rsoperator_module: its re-export is inconfig/mod.rs(D2: drain plane_driver/serve.rs::TABLES — the generation carries its admin table (stacked on #1482) #1485).cost.rsresolve_model_alias: its only caller isbusbar-core-admin/src/v1/service.rs(D2: drain plane_driver/serve.rs::TABLES — the generation carries its admin table (stacked on #1482) #1485).tests/members/audit/sign_tests.rsrich_inputs: one caller ispublished_recipe_tests.rs(C12: delete tests that prove internal seams, status rows or censuses #1657).config/migrate.rsuniq_def_nameand the nestedexport_mut: both are on the 1.4.x/1.5.x config migration path, which is a hard no-touch.auth/tests/acceptance_1_5_5_tests.rsBuf/capture: the suite asserts on fmt-rendered lines (level text" WARN ",diag=BUSBAR-…).WarnCapturerecords fields without levels, so moving to it would change assertions.governance/testsHungDenylistStore,BrokenDenylistStore,MeteringDownStore,FlakyStore,RecordingBarrierStore,BlockingDenylistStore,FailGetUsage,ReadOnlyStore,CountingStore,FailDeleteStore,FailListKeysAfterDeleteStore,PanicOnPutKeyStoreandRefreshBlipStore(13 items): the replacement is a new genericDelegatingStoreabstraction, and its proposed hometest_support/mod.rsis changed by C2: delete the kernel egress engine; the connector is the one outbound path (supersedes #1230) #1656 and D2: drain plane_driver/serve.rs::TABLES — the generation carries its admin table (stacked on #1482) #1485.ledger/checkpoint_tests.rsthe_head_order_does_not_change_the_body: not subsumed. It is the only test covering the no-snapshotCheckpoint::sealencoding (the legacy read-back path); the other test covers onlyseal_as_of.ledger/cost/history_tests.rscard_at/overlapping_history: the other copy is in thebusbar-kernel-ledgercrate's private tests. Sharing it would need a new test-support surface in that crate.tests/plane_driver.rsWay/ways(): not single-variant.plane_driver_cases.rsis also included bycrates/busbar/tests/plane_driver.rs, whereWayis{Linked, Dropped}.Within this batch, the LCG item covered only the in-kernel copy. The
busbar-kernel-ledgerandcrates/busbar/testscopies are in other crates.Verification
cargo build,cargo clippy -p busbar-kernel --all-targets -- -D warnings,cargo check --workspace --all-targetsandcargo test -p busbar-kernel --no-fail-fastwere all green locally, with one exception.seal_tests::a_second_definition_of_the_kernels_root_symbol_does_not_linkfails locally on macOS: it asserts how the system linker behaves, and its code is untouched here.sign_tests::the_signature_costs_the_same_whatever_the_record_holdsfailed once under parallel load (it is a timing test) and passed when rerun.production LOC (loc-tool): 251675 → 251670