Repository navigation
streaming broker: a minted ek_ secret with no stated expiry is refused (X-2204) - #949
Merged
Merged
Conversation
…d (X-2204) read_minted defaulted an absent expires_at to 0 and carried it to the browser as expires_at_unix: 0, a figure that is not an instant. The expiry is now required and non-zero; an answer without one is refused (the secret is not echoed in the refusal). RED: broker_tests a_minted_answer_with_no_stated_expiry_is_refused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO X-2204 (docs/design/1.6.0-TODO.md:4039): an absent provider expiry became
0and was carried to the browser.Fix (
crates/busbar-plane-streaming/src/broker.rs, the surviving streaming plane):expires_atis required and non-zero; a mint answer without one is refused with a text that does not echo the secret. The legacybusbar-voice/src/topology/minter_https.rs:178carries the same#[serde(default)]shape; that crate is #503's (voice -> streaming fold), so it is not touched here.1.5.5: had no
ek_minting (noclient_secretsroute), so there is no parity cell.RED:
crates/busbar-plane-streaming/src/tests/broker_tests.rsa_minted_answer_with_no_stated_expiry_is_refused(absent,null,0).