fix: block prev pagination while another query is loading - #1891
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
MartinCupela,
isekovanic,
oliverlaz and
szuperaz
as code owners
September 29, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: block prev pagination while another query is loading
CLA
Description of the changes, What, Why and How?
BasePaginator.canExecuteQueryonly checkedisLoadingfor thenextdirection because of operator precedence:(!isLoading && next && hasNext) || (prev && hasPrev). Callingprev()twice quickly sent two requests with the same cursor, and both results were appended toitems.The
isLoadingcheck now applies to both directions. A test inBasePaginator.test.tsstarts aprev()query, callsprev()again while it is in flight, and checks that only one query is dispatched. The test fails on the previous code (3 query calls instead of 2) and passes with this change.Changelog
prevpage queries while a paginator is loading.