fix: remove hard-deleted thread replies shown in the channel from the message list - #1892
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
MartinCupela,
isekovanic,
oliverlaz and
szuperaz
as code owners
September 29, 2026 10:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: remove hard-deleted thread replies shown in the channel from the message list
CLA
Description of the changes, What, Why and How?
ChannelState.removeMessageremoves a thread reply fromthreads[parent_id]and skips the channel message sets (if / else). A reply sent withshow_in_channel: trueexists in both places, so amessage.deletedevent withhard_deleteremoved it from the thread only and left it inchannel.state.messages.removeMessagenow also removes the message from the channel message sets whenshow_in_channelis true, or when the thread is not loaded (the previous behavior). Theshow_in_channelfield is read from the message passed by themessage.deletedhandler.A test in
channel_state.test.jshard-deletes a reply that is shown in the channel and checks both lists. The test fails on the previous code and passes with this change.channel_state.test.jsandchannel.test.jspass (235 tests).Changelog
show_in_channelstaying in the channel message list.