Skip to content

data(brand): Korean descriptions + Wikidata logos for new display/PC brands - #109

Merged
Seungpyo1007 merged 2 commits into
mainfrom
data/import-staging
Jul 8, 2026
Merged

Seungpyo1007 merged 2 commits into
mainfrom
data/import-staging

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Jul 8, 2026 •

Copy link
Copy Markdown
Member

Summary

Brand metadata enrichment for the 18 new display/PC brands added while wiring the laptop and monitor categories.

  • description_ko added for all 18 new brands (ViewSonic, AOpen, AOC, Planar, Chuwi, Thermaltake, Elo, Targus, and 10 others) — concise Korean one-liners describing each brand.
  • logo_url added for 8 brands via domain-matched Wikidata P154 (logo image), resolved to commons.wikimedia.org/.../Special:FilePath/... URLs. Only entities whose Wikidata P856 (official website) matched the brand's stored website were used, so no mismatched logos.
  • Brands without a confidently-matched Wikidata entity keep logo_url: null (no fabrication).

All records remain verified: false. Validation passes (app/validate.py). Public dump regenerated — only the 18 changed brand detail pages under site/public/v1/brands/<slug>/index.json.

Closes #1

Complete the metadata for the 18 display/PC brands: description_ko for
all 18, and logo_url for the 8 with a domain-matched Wikidata entity +
P154 logo (ViewSonic, AOpen, AOC, Planar, Chuwi, Thermaltake, Elo,
Targus). The rest have no Wikidata logo (left null).

Refs #1
@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 TechEngine · data validation

category   changed   verified
brand         18        false
  • python -m app.validate → ✅ passed (0 errors) across all 10 categories (108,575 records).
  • description_ko set for 18/18 new brands; logo_url set for 8/18 (Wikidata P154, website-matched).
  • Dump regenerated: 18 brand detail pages under v1/brands/<slug>/. No churn beyond the changed set.

No schema changes — additive field fills only.

@Seungpyo1007

Copy link
Copy Markdown
Member Author

🤖 TechEngine · verify (Tier 0)

Logos sourced by reality-checked linkage, not guesswork:

  • Candidate Wikidata entity accepted only when its P856 (official website) equals the brand's stored website domain → then its P154 logo file → Special:FilePath URL.
  • 10 brands had no confident match and stay logo_url: null (no fabricated assets).
  • All records remain verified: false; promotion stays with the verify-network job.

Safe to rebase-merge.

@Seungpyo1007
Seungpyo1007 merged commit 816fcfc into main Jul 8, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in TechAPI-Project Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TechAPI dataset roadmap and status: all categories (1989-2026)

1 participant