data(brand): Korean descriptions + Wikidata logos for new display/PC brands - #109
Merged
Merged
Conversation
Complete the metadata for the 18 display/PC brands: description_ko for all 18, and logo_url for the 8 with a domain-matched Wikidata entity + P154 logo (ViewSonic, AOpen, AOC, Planar, Chuwi, Thermaltake, Elo, Targus). The rest have no Wikidata logo (left null). Refs #1
Member
Author
🤖 TechEngine · data validation
No schema changes — additive field fills only. |
Member
Author
🤖 TechEngine · verify (Tier 0)Logos sourced by reality-checked linkage, not guesswork:
Safe to rebase-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brand metadata enrichment for the 18 new display/PC brands added while wiring the laptop and monitor categories.
commons.wikimedia.org/.../Special:FilePath/...URLs. Only entities whose Wikidata P856 (official website) matched the brand's stored website were used, so no mismatched logos.logo_url: null(no fabrication).All records remain
verified: false. Validation passes (app/validate.py). Public dump regenerated — only the 18 changed brand detail pages undersite/public/v1/brands/<slug>/index.json.Closes #1