data(smartphone): compute display ppi from resolution + size (51,557 records) - #112
Merged
Merged
Conversation
…57 records Fills display.ppi = round(sqrt(w^2+h^2)/size_inch) for records that have a resolution and screen size but no ppi. Pure geometry from existing fields — no new/external data. Validated against records that already have ppi: 89% exact, 10% off-by-1 (rounding); the rare larger deltas are Apple's marketed/rounded figures. Coverage ~26% -> ~81%. Refs #1
Member
Author
🤖 TechEngine · data validation
|
Member
Author
🤖 TechEngine · verify (Tier 0)Derivation, not import — the density is computed from
|
Seungpyo1007
added a commit
that referenced
this pull request
Jul 9, 2026
… fields Applies the same two derivations used for smartphones (#111, #112) to the tablet/watch/pda catalogues: parse launch os_version from the `os` string, and compute display.ppi = round(sqrt(w^2+h^2)/size_inch). Deterministic, no new data. tablet +2656 os_version / +2080 ppi; watch +202 / +279; pda +16 / +54. Refs #1
Seungpyo1007
added a commit
that referenced
this pull request
Jul 9, 2026
… fields Applies the same two derivations used for smartphones (#111, #112) to the tablet/watch/pda catalogues: parse launch os_version from the `os` string, and compute display.ppi = round(sqrt(w^2+h^2)/size_inch). Deterministic, no new data. tablet +2656 os_version / +2080 ppi; watch +202 / +279; pda +16 / +54. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Computes display pixel density (
ppi) for smartphones from fields already in the record — pure geometry, no new/external data.display.ppi = round(sqrt(width² + height²) / size_inch)for 51,557 smartphones that have a resolution and screen size but noppi.ppi~26% → ~81%.ppi: 89% exact match, 10% off-by-1 (rounding), only 0.4% differ by more — and those are Apple's marketed/rounded figures (e.g. iPhone "326") vs the true geometric density.Same deterministic method PR #107 used for monitors & laptops, now applied to the smartphone catalogue. All
verified: false. Validation passes. Dump regenerated — 51,557 changed smartphone detail pages.Closes #1