data: add laptop category — 970 laptops (first non-mobile class) - #102
Merged
Merged
Conversation
Mirror the TechEngine laptop validator: LAPTOP_REQUIRED fields, ranges (ram_gb 1-256, storage_gb, weight_g 300-6000, msrp 50-50000), brand required + optional cpu/gpu FK checks, and the variant path convention. Refs #1
New `laptop` category seeded from the abhinavflac/laptops-specs-dataset (GitHub, MIT). Lenovo and HP lines with cpu_name/gpu_name, RAM, storage, display and INR->USD MSRP. Bulk import, verified:false. Refs #1
More abhinavflac/laptops-specs-dataset laptops (Asus, Acer, MSI gaming and mainstream lines). verified:false. Refs #1
Remaining abhinavflac/laptops-specs-dataset laptops (Dell, Apple, Samsung, Microsoft, Infinix, Gigabyte, Motorola). verified:false. Refs #1
Member
Author
🤖 Review — PASS
Data-change summary
Example records
Heuristic notes
Site build
|
Member
Author
📊 Dataset stats (post-merge projection)
New category: laptops (970) — the dataset's first non-mobile device class. Public laptop data is small (~1k rich records), so this is near the ceiling for a single source; more can come from additional laptop datasets later. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds a new
laptopcategory to the dataset — the first non-mobile device class — with 970 laptops. This is the TechAPI half; the engine half (model/schema/router/seed/dump/validate) merged in TechEngine PR #39 and the submodule pin was bumped tod1c3b0bon main, so laptops now validate, serve and dump like any other category.verified: false.brandis a required FK;cpu/gpuare optional FKs (rawcpu_name/gpu_namealways kept). Fields:ram_gb,storage_gb,display,device_category,msrp_usd,os.Commits (each
Refs #1): validator rule, 3 brand-group data commits, and the surgical dump refresh (newlaptopscollection).Closes #1
Source
abhinavflac/laptops-specs-dataset(GitHub, MIT). MSRP converted INR→USD (~÷83);release_dateyear derived from the CPU generation (Intel/AMD/Apple naming), placeholderYYYY-01-01.variant.source_rowcites the CSV row.Dump
Regenerated via TechEngine
app.dumpat the laptop-supporting submodule pind1c3b0b. Laptops are unscored (no/score), so the dump addsv1/laptops/**(detail only) + a manifest entry. Only the new collection + manifest are committed — no churn on existing records.Checklist
python -m app.validate— ✅ passed (full dataset incl. 970 laptops)python TechEngine/integrity_check.py data --strict— ✅ no hard anomaliesgit diff --check— ✅ cleandata/laptop/<brand>/<year>/<base>/<slug>.jsonpaths, kebab-case unique slugs,source_urlspresent