data: add 18 display/PC brands + unlock 122 monitors & 16 laptops - #106
Merged
Merged
Conversation
Add 18 established display/PC manufacturers missing from the catalog so their monitors/laptops can be imported: ViewSonic, AOpen, AOC, Sceptre, Planar, Alienware, Chuwi, Thermaltake, Colorful, Thomson, Elo, Kensington, Targus, KOORUI, Pixio, INNOCN, InnoView, Lilliput. verified:false, categorized pc-oem (Alienware sub-brand). Refs #1
122 monitors unlocked by the new brand records — AOpen (70), ViewSonic, Sceptre, KOORUI, AOC, Lilliput, Planar, InnoView, Alienware, Pixio, INNOCN, Kensington. Same Amazon dataset (CC BY 4.0). verified:false. Refs #1
16 laptops unlocked by the new brand records — Alienware (7), Thomson, Chuwi, Colorful. abhinavflac dataset; cpu/gpu linked where matched. verified:false. Refs #1
Add the 18 new brands, 122 monitors and 16 laptops to the static v1 dump and bump the brand/laptop/monitor index and manifest counts (brands 189->207, laptops 1935->1951, monitors 760->882). Regenerated via app.dump @ bfdd4d9; only the new records + affected indexes. Refs #1
Member
Author
🤖 Review — PASS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds 18 established display/PC brands that were missing from the catalog, which unlocks devices previously skipped on import: +122 monitors and +16 laptops.
pc-oem, with country/founded-year/description.All
verified: false. Only truly-established brands were added — one-off obscure Amazon-seller brands (Domyfan, Fiodio, cocopar, …) were deliberately left out to keep the brand catalog clean.Commits (each
Refs #1): brand records, monitor import, laptop import, surgical dump refresh.Closes #1
Checklist
python -m app.validate— ✅ passed (brands valid: ISO country, pc-oem category, path)python TechEngine/integrity_check.py data --strict— ✅ no hard anomaliesgit diff --check— ✅ cleansource_urlspresent