data: recover 53 SoC-variant phones + add ppi to monitors & laptops - #107
Merged
Merged
Conversation
53 more cigarplug/scrape-gsma phones (Apple iPhone 5/5c/5s/6…, plus Snapdragon 855+, Helio P70M, Dimensity 1000+, Huawei K3V2E devices) that were skipped only because the SoC matcher missed naming variants (A-series, +/M suffixes). Mapped to the EXISTING SoC records — no new SoCs. verified:false. Refs #1
Derive pixel density (ppi = diagonal_px / size_inch) for all 882 monitors from their resolution + screen size. Deterministic, no external data. Refs #1
Add display.ppi (diagonal_px / size_inch) to all 1,951 laptops with a resolution + size. Deterministic. Refs #1
Add the 53 recovered smartphones to the dump (smartphones 93343->93396) and refresh all monitor + laptop detail files with the newly-computed ppi field. Regenerated via app.dump @ bfdd4d9; only the new phones, the monitor/laptop details and the smartphone index + manifest are committed (no churn on other categories). Refs #1
Member
Author
🤖 Review — PASS
|
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
An enrichment cycle: recover more phones + add pixel-density to displays.
+/Msuffixes). Mapped to the existing SoC records via explicit overrides — no new SoCs, no duplicates.ppicomputed for all 882 monitors (diagonal_px / size_inch).display.ppicomputed for all 1,951 laptops.All deterministic / sourced;
verified: falseon the new phones. Commits (eachRefs #1): phone recovery, monitor ppi, laptop ppi, surgical dump.Closes #1
Checklist
python -m app.validate— ✅ passed (53 phones link to existing SoCs; ppi in range)python TechEngine/integrity_check.py data --strict— ✅ no hard anomaliesgit diff --check— ✅ clean