data(cpu): fill process node and L3 cache for 540 Xeon CPUs - #133
Merged
Merged
Conversation
540 Xeon records gain 1,037 previously-null fields (process_node 493,
l3_cache_mb 540, boost_clock_ghz 4), sourced from the per-generation
"List of Intel Xeon processors (<uarch>-based)" pages.
Those pages do not use wikitext tables: every CPU is a {{cpulist|...}}
template call with named parameters (model=, cores=, l3=, tdp=, turbo=),
so values are read by name and the column-shift hazard of the table-based
pages cannot occur here. A row is still only used when the data already
held agrees -- core count exactly, and TDP within 1 W when both sides have
it (20 of 656 matches were dropped on those checks).
The process node comes from the page's microarchitecture, which is
unambiguous per generation (Skylake 14 nm, Haswell 22 nm, Ice Lake 10 nm,
Sandy Bridge 32 nm). Pages that mix generations -- Core-based, Nehalem,
P6 -- were left without a node rather than guessed.
Refs #1
Regenerates site/public/v1/cpus for the 540 records changed in the previous commit, with the engine at the pinned submodule commit so scoring output is unchanged. Only pages whose content actually differs are committed; the 7,415 pages that differed solely by created_at/updated_at are left alone. Refs #1
github-actions
Bot
added
data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
540 Xeon records gain 1,037 previously-null fields —
process_node493,l3_cache_mb540,boost_clock_ghz4 — from the per-generation List of Intel Xeon processors (<uarch>-based) pages.Combined with #132, CPU
process_nodecoverage moves 24% → 46% andl3_cache_mb19% → 48%.Why these pages needed different handling
The Xeon hub page is only an index of links, which is why the earlier run found 0 rows there. The real data lives on 16 per-generation sub-pages, and those do not use wikitext tables at all — each CPU is a template call:
Values are read by parameter name, so the column-shift hazard that required so much guarding in #132 cannot occur here.
Correctness
process_nodecomes from the page's microarchitecture, which is unambiguous per generation (Skylake 14 nm, Haswell 22 nm, Ice Lake 10 nm, Sandy Bridge 32 nm). Pages that mix generations — Core-based, Nehalem, P6 — were left without a node rather than guessed.Only empty fields are written, nothing existing is overwritten,
verifiedis untouched, and the specific generation page is recorded insource_urls.python -m app.validate→ Data validation passed. Dump refreshed for the 540 changed pages only.Closes #1