fix(data/laptop): MacBook year folders and dirty cpu_name values - #192
Merged
Merged
Conversation
Move 2025 M4 Air and M5 Pro records out of the 2024 folder, set availability dates from Apple Newsroom, and normalize chip names against Support tech specs.
Collapse scrape artifacts such as "Snapdragon Snapdragon X Elite" and "Intel 210H 210H" to vendor-canonical names, citing Qualcomm/Intel/OEM specs in source_urls.
github-actions
Bot
added
bug
Seungpyo1007
force-pushed
the
fix/laptop-year-cpu-name
branch
from
September 18, 2026 11:02
d0f2026 to
7b81791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes two laptop-data issues found in a read-only audit:
release_datefor 2025 MacBooks — several M4 MacBook Air and M5 MacBook Pro records lived underdata/laptop/apple/2024/with placeholderrelease_date: 2024-01-01, which also made the Apple laptop year tree stop at 2024.cpu_namevalues — scrape artifacts likeApple M4 M4,Snapdragon Snapdragon X Elite, andIntel 210H 210H.Source
Apple (Newsroom + Support tech specs):
CPU naming:
Apple M3/Apple M4/Apple M4 Pro/Apple M4 Max/Apple M5)X1E-*kept as EliteIntel Core 5 210Hfrom Intel ARK + Lenovo PSREF for the IdeaPad Slim 5 16IRH10R rowChanges
apple/2024/→apple/2025/viagit mvrelease_date+source_urls(2024 M3 Air / M4 Pro stay in 2024 with real availability dates)cpu_namevalues across Apple and other OEMs (Snapdragon / Intel)Dump note
site/public/v1was not regenerated in this PR. Localpython -m app.dumpagainst the pinned TechEngine was started but aborted after ~25 minutes still mid-run: the full tree is ~190k+ JSON records (≈93k smartphones alone, plus large software/website collections), so a complete dump is multi-hour work on this machine. Please run TechEnginedump-refresh/weekly-refresh(or regenerate CI-side) before merge if the dump must ship in the same PR.Checklist
develop(mainonly moves through release PRs)python -m app.validatepasses locallydata/<category>/<...>/<slug>.jsonpathsource_urlscites at least one canonical referencesite/public/v1) — deferred; see Dump note