Skip to content

Correct storage-derived RAM values in device records - #281

Merged
Seungpyo1007 merged 15 commits into
developfrom
fix/ram-equals-storage
Sep 25, 2026
Merged

Seungpyo1007 merged 15 commits into
developfrom
fix/ram-equals-storage

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

Corrected 40 storage-derived RAM values across smartphones, tablets, and watches. Each change updates ram_gb, matching variant.memory.ram_gb when present, and adds the evidence URL to source_urls.

Suspects: 77 before → 37 after; corrected: 40; unresolved: 37. No PDA records met the implausibility filter.

Sample corrections

Record Before (GB) After (GB) Evidence
data/smartphone/alcatel/2018/5v.json 32 3 Source
data/smartphone/apple/2018/watch-series-4.json 16 1.0 Source
data/smartphone/dell/2012/xps-10.json 64 2 Source
data/smartphone/motorola/2011/mt917.json 16 1 Source
data/smartphone/samsung/2010/i909-galaxy-s.json 16 0.5 Source
data/smartphone/t-mobile/2011/springboard.json 16 1 Source
data/tablet/vodafone/2013/smart-tab-iii-7/smart-tab-iii-7.json 16 1 Source
data/watch/xiaomi/2023/redmi-watch-4/xiaomi-redmi-watch-4-aitoolbuzz-13115-16gb-16gb-4g-lte.json 16 0.031 Source

Unresolved

The following records remain unchanged because a same-model sibling, Wikipedia article, or manufacturer specification did not clearly establish RAM:

  • data/smartphone/dell/2011/streak-7-wi-fi.json — currently 16 GB
  • data/smartphone/dell/2011/streak-7.json — currently 16 GB
  • data/smartphone/lg/2011/optimus-big-lu6800.json — currently 16 GB
  • data/smartphone/lg/2011/revolution.json — currently 16 GB
  • data/smartphone/lg/2012/optimus-pad-lte.json — currently 32 GB
  • data/smartphone/lg/2011/optimus-big-lu6800/lg-optimus-big-lu6800-aitoolbuzz-5239-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/lg/2011/optimus-big-lu6800/lg-optimus-big-lu6800-allphones-4332-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/lg/2011/revolution/lg-revolution-aitoolbuzz-5326-16gb-16gb-4g-lte.json — currently 16 GB
  • data/smartphone/lg/2011/revolution/lg-revolution-allphones-4313-16gb-16gb-4g-lte.json — currently 16 GB
  • data/smartphone/samsung/2009/vodafone-360-h1.json — currently 16 GB
  • data/smartphone/samsung/2010/i9010-galaxy-s-giorgio-armani.json — currently 16 GB
  • data/smartphone/samsung/2010/m190s-galaxy-s-hoppin.json — currently 16 GB
  • data/smartphone/samsung/2011/galaxy-s-wifi-5-0.json — currently 16 GB
  • data/smartphone/samsung/2011/w999.json — currently 16 GB
  • data/smartphone/samsung/2012/galaxy-player-70-plus.json — currently 32 GB
  • data/smartphone/samsung/2009/vodafone-360-h1/samsung-vodafone-360-h1-aitoolbuzz-10363-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/samsung/2009/vodafone-360-h1/samsung-vodafone-360-h1-allphones-7258-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/samsung/2010/i9010-galaxy-s-giorgio-armani/samsung-i9010-galaxy-s-giorgio-armani-allphones-7341-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/samsung/2010/m190s-galaxy-s-hoppin/samsung-m190s-galaxy-s-hoppin-aitoolbuzz-10123-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/samsung/2010/m190s-galaxy-s-hoppin/samsung-m190s-galaxy-s-hoppin-allphones-7345-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/samsung/2011/galaxy-s-wifi-5-0/samsung-galaxy-s-wifi-5-0-aitoolbuzz-9750-16gb-16gb-2g.json — currently 16 GB
  • data/smartphone/samsung/2011/galaxy-s-wifi-5-0/samsung-galaxy-s-wifi-5-0-allphones-7365-16gb-16gb.json — currently 16 GB
  • data/smartphone/samsung/2011/i9010-galaxy-s-giorgio-armani/samsung-i9010-galaxy-s-giorgio-armani-aitoolbuzz-10068-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/samsung/2011/w999/samsung-w999-allphones-6688-16gb-16gb-2g.json — currently 16 GB
  • data/smartphone/samsung/2012/galaxy-player-70-plus/samsung-galaxy-player-70-plus-aitoolbuzz-9708-32gb-32gb-2g.json — currently 32 GB
  • data/smartphone/samsung/2012/w999/samsung-w999-aitoolbuzz-10372-16gb-16gb-3g.json — currently 16 GB
  • data/smartphone/vertu/2010/ascent-2010.json — currently 32 GB
  • data/smartphone/vertu/2011/ascent-ferrari-gt.json — currently 32 GB
  • data/smartphone/vertu/2013/constellation-2013.json — currently 32 GB
  • data/smartphone/vodafone/2009/360-h1.json — currently 16 GB
  • data/smartphone/vodafone/2018/360-h2.json — currently 16 GB
  • data/tablet/lg/2012/optimus-pad-lte/lg-optimus-pad-lte-aitoolbuzz-5289-32gb-32gb-4g-lte.json — currently 32 GB
  • data/tablet/lg/2012/optimus-pad-lte/lg-optimus-pad-lte-allphones-4362-32gb-32gb-4g-lte.json — currently 32 GB
  • data/watch/huawei/2022/watch-gt-3-pro/huawei-watch-gt-3-pro-aitoolbuzz-3846-32gb-32gb-4g-lte.json — currently 32 GB
  • data/watch/huawei/2023/watch-ultimate/huawei-watch-ultimate-aitoolbuzz-3854-32gb-32gb-4g-lte.json — currently 32 GB
  • data/watch/huawei/2023/watch-ultimate-design/huawei-watch-ultimate-design-aitoolbuzz-3855-32gb-32gb-4g-lte.json — currently 32 GB
  • data/watch/xiaomi/2024/watch-s4-sport/xiaomi-watch-s4-sport-aitoolbuzz-13133-32gb-32gb-4g-lte.json — currently 32 GB

Verification

PYTHONIOENCODING=utf-8 python -m app.validate passed. Structural diff audit confirmed only RAM fields and source_urls changed.

Refs #1

@github-actions github-actions Bot added data Dataset changes enhancement New feature or request labels Sep 25, 2026
@Seungpyo1007 Seungpyo1007 added bug Something isn't working and removed enhancement New feature or request labels Sep 25, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

135 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 102
    "Yellow" : 33
    "Red" : 0
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
soc 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨 9 2 7 0 22.2%
smartphone 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 46 25 21 0 54.3%
tablet 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 5 1 4 0 20.0%
watch 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨 38 37 1 0 97.4%
cpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 37 37 0 0 100.0%
All 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨 135 102 33 0 75.6%

Full-dataset baseline

106356 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 24223
    "Yellow" : 81038
    "Red" : 1095
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 207 122 85 0 58.9%
soc 🟩🟨🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥 2105 253 831 1021 12.0%
smartphone 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93407 17956 75383 68 19.2%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 292 3162 1 8.5%
watch 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 442 80 358 4 18.1%
pda 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 140 83 57 0 59.3%
gpu 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 2093 1274 819 0 60.9%
cpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨🟥 4507 4163 343 1 92.4%
All 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟥 106356 24223 81038 1095 22.8%

Hard violations (forced red):

Count Check
1 !boost_ge_base

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@Seungpyo1007
Seungpyo1007 merged commit ca602c8 into develop Sep 25, 2026
5 checks passed
@Seungpyo1007
Seungpyo1007 deleted the fix/ram-equals-storage branch September 25, 2026 12:30
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
New hard integrity anomalies vs PR base PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 0 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 34 0 0 0 0
tablet 0 5 0 0 0 0
watch 0 1 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

smartphone modified

  • smartphone/alcatel/2018/5v.json - 5v
  • smartphone/alcatel/2018/7.json - 7
  • smartphone/apple/2018/watch-series-4-aluminum.json - Watch Series 4 Aluminum
  • smartphone/apple/2018/watch-series-4.json - Watch Series 4
  • smartphone/apple/2019/watch-edition-series-5.json - Watch Edition Series 5
  • smartphone/apple/2019/watch-series-5-aluminum.json - Watch Series 5 Aluminum
  • smartphone/apple/2019/watch-series-5.json - Watch Series 5
  • smartphone/asus/2019/zenfone-live-l2.json - ZenFone Live (L2)
  • smartphone/dell/2012/xps-10.json - XPS 10
  • smartphone/gionee/2013/elife-e7-mini.json - Elife E7 Mini
  • smartphone/lg/2011/jil-sander-mobile.json - Jil Sander Mobile
  • smartphone/lg/2011/jil-sander-mobile/lg-jil-sander-mobile-aitoolbuzz-5040-16gb-16gb-3g.json - LG Jil Sander Mobile
  • smartphone/lg/2011/jil-sander-mobile/lg-jil-sander-mobile-allphones-4348-16gb-16gb-3g.json - LG Jil Sander Mobile
  • smartphone/lg/2018/q-stylo-4.json - Q Stylo 4
  • smartphone/motorola/2011/mt917.json - MT917
  • ... 19 more

tablet modified

  • tablet/honor/2022/pad-x8-lite/honor-pad-x8-lite-aitoolbuzz-2983-32gb-32gb-4g-lte.json - Honor Pad X8 Lite
  • tablet/honor/2022/pad-x8-lite/honor-pad-x8-lite-allphones-2850-32gb-32gb.json - Honor Pad X8 Lite
  • tablet/t-mobile/2011/g-slate/g-slate.json - G-Slate
  • tablet/vodafone/2013/smart-tab-iii-10-1/smart-tab-iii-10-1.json - Smart Tab III 10.1
  • tablet/vodafone/2013/smart-tab-iii-7/smart-tab-iii-7.json - Smart Tab III 7

watch modified

  • watch/xiaomi/2023/redmi-watch-4/xiaomi-redmi-watch-4-aitoolbuzz-13115-16gb-16gb-4g-lte.json - Xiaomi Redmi Watch 4

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 207 122 85 0 207 58.9%
soc 2105 193 1912 0 2105 9.2%
smartphone 93407 17501 75906 0 93407 18.7%
tablet 3455 273 3182 0 3455 7.9%
watch 442 39 403 0 442 8.8%
pda 140 74 66 0 140 52.9%
gpu 2093 1028 1065 0 2093 49.1%
cpu 4507 2869 1638 0 4507 63.7%
all 106356 22099 84257 0 106356 20.8%

Warning

Tracked verified coverage is below 50% for tablet 7.9% (273/3455), watch 8.8% (39/442), soc 9.2% (193/2105), smartphone 18.7% (17501/93407), all 20.8% (22099/106356), gpu 49.1% (1028/2093).
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • The integrity gate blocks only hard anomalies introduced by this PR relative to its merge base.
  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py (PR head compared with PR base)
loaded CPU=4507 GPU=2093
Integrity section Flagged lines
structural 20
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 155
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working data Dataset changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants