Skip to content

ci: dump after merge instead of per PR; full validation on push only - #353

Merged
Seungpyo1007 merged 1 commit into
developfrom
ci/dump-on-develop
Sep 30, 2026
Merged

Seungpyo1007 merged 1 commit into
developfrom
ci/dump-on-develop

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Step 9 of #350.

  • New dump-develop.yml: on push to develop touching data/**, run the pinned TechEngine app.dump --changed-since <before> and commit site/public back to develop (rebase-retry). Its commit only touches site/public, so the path filter prevents a loop. Falls back to a full dump if the pinned engine predates --changed-since. Manual run: workflow_dispatch with full.
  • validate-data.yml: bundled full self-validate runs on pushes only; PRs rely on the scoped engine validation.
  • Effect on the work rules: the dump is no longer the last commit of every data PR. Existing PRs that still carry one remain valid (dump_check only compares when the dump is touched).
  • Risk to watch on the first data merge: the push from github-actions[bot] to develop must be allowed by branch protection. If it is refused, the job fails loudly (no silent drift) and the dump can still be run with the old procedure.

Closes #297

dump-develop regenerates site/public from the pinned TechEngine after data
lands on develop, restricted to the collections the push can affect, and
commits it back. Data PRs therefore no longer need a dump commit, which was the
33 minute step every rebase invalidated. PRs keep only the scoped engine
validation; the full bundled self-validate runs on pushes.

Refs #350
@Seungpyo1007 Seungpyo1007 added the ci CI and workflow changes label Sep 30, 2026
@Seungpyo1007 Seungpyo1007 self-assigned this Sep 30, 2026
@Seungpyo1007
Seungpyo1007 merged commit 8ef2e4b into develop Sep 30, 2026
1 check passed
@Seungpyo1007
Seungpyo1007 deleted the ci/dump-on-develop branch September 30, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI and workflow changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Engine, TechEngineBot and automation (workstream)

1 participant