data(watch): drop invalid sub-1GB storage_options_gb from Huawei 2018 watches - #53
Merged
Merged
Conversation
… watches Huawei Watch GT/Magic carried storage_options_gb: [0.125] (128 MB), which is not a valid integer-GB value: app.validate requires int >= 1 and TechEngine's MobileDeviceRead rejects the fractional float, breaking the static dump. Remove the field (the optional storage list) so the records validate and dump cleanly. Refs #1
… watches Huawei Watch GT/Magic carried storage_options_gb: [0.125] (128 MB), which is not a valid integer-GB value: app.validate requires int >= 1 and TechEngine's MobileDeviceRead rejects the fractional float, breaking the static dump. Remove the field (the optional storage list) so the records validate and dump cleanly. Refs #1
github-actions
Bot
added
data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Huawei Watch GT and Huawei Watch Magic (2018) carried
storage_options_gb: [0.125](128 MB stored as fractional GB). That is not a valid integer-GB value:app.validate._check_storage_options_gbrequiresint >= 1.MobileDeviceReadschema rejects the fractional float, which breaks the static dump (test_dumpfails:Input should be a valid integer, got 0.125).Because TechEngine's
test.ymlchecks out TechAPImainlive and seeds from it, this one bad value fails the test suite on every TechEngine PR.Fix
Remove the optional
storage_options_gbfield from both records (surgical text removal — no reserialization, all other fields byte-identical). 128 MB cannot be represented as integer GB and the field is optional, so dropping it is the clean fix.Effect
Unblocks TechEngine CI (and the weekly-refresh dump). The public
site/public/v1dump is regenerated by the refresh pipeline.Closes #1