feat(verify): generalize Wikipedia image backfill to device categories - #108
Merged
Merged
Conversation
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records in laptop, monitor, tablet, watch and PDA categories can now use the same conservative Wikipedia-to-Commons image backfill as smartphones.
--categorydefaults tosmartphone, preserving existing commands, offsets, limits and image-selection rules.The shared append-only cache uses repository-relative paths, so decisions remain distinct across categories. Incompatible record shapes produce explicit skips instead of interrupting a batch; existing image metadata is preserved.
Validation: 23 focused tests pass locally;
ruff check app testsandmypy apppass locally and in CI. CI's full suite passed all 534 tests with 77.62% coverage, above the 60% gate. Full-dataset schema validation also passed.The five real
--apply --include-missing-keyruns checked 163 records and added 28 images: laptop 12/44, monitor 0/0, tablet 11/48, watch 4/55, PDA 1/16. All existing matching, image and license filters remain unchanged.Refs #295
Refs GetTechAPI/TechAPI#295