perf(verify): load only the changed records for score --changed - #114
Merged
Merged
Conversation
`app.verify score --changed` parsed all ~190k seed files and then filtered down to the diff. `_load`/`load_all` now take an optional set of changed paths; brand and soc stay fully loaded because foreign-key checks and SoC release dates depend on them. `pr` keeps the full load until its baseline moves to status.json. Refs GetTechAPI/TechAPI#350
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of GetTechAPI/TechAPI#350.
score --changedused to parse every seed file and then filter to the PR diff._load/load_allnow accept the changed path set; brand/soc are still loaded whole so FK and release-date checks are unchanged.pris untouched (its full-dataset baseline goes to status.json in the next step).Tests:
tests/verifyall pass; newtest_scoped_load.pycovers scoped vs full load. Not benchmarked on real data yet (the data tree is not checked out locally).