fix(test): stop hardcoding brand source_urls in integration test - #76
Merged
Merged
Conversation
Brand source_urls grow as verification backfills add references (e.g. Wikidata); assert membership instead of exact list equality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1
오늘 Brand Wikidata 백필(TechAPI PR #205/#207/#209)로 samsung 브랜드의 source_urls에 Wikidata URL이 정상 추가됐는데, 이 통합 테스트가 정확한 리스트 일치(
== ["https://www.samsung.com"])를 하드코딩해서 CI가 깨졌습니다. 앞으로도 검증 백필로 source_urls가 늘어날 수 있으니, samsung.com URL이 포함돼 있는지만 확인하도록 완화했습니다.이 실패는 다른 TechEngine PR들의 CI도 막고 있어서 별도로 먼저 처리합니다.